Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alpine's assert-statement conversion special case #8438

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

tautschnig
Copy link
Collaborator

In d44bfd3 we added a special case to catch Alpine Linux' assert structure. The match, however, was not sufficiently specific as it just accepted any statement that follows the actual assertion.

Fixes: #8436

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (dd54106) to head (4b5fae8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8438      +/-   ##
===========================================
- Coverage    78.19%   78.17%   -0.02%     
===========================================
  Files         1726     1726              
  Lines       189068   189114      +46     
  Branches     18273    18265       -8     
===========================================
+ Hits        147841   147844       +3     
- Misses       41227    41270      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig
Copy link
Collaborator Author

Requires #8435 for CI to pass.

@kroening kroening assigned tautschnig and unassigned kroening and peterschrammel Sep 4, 2024
In d44bfd3 we added a special case to catch Alpine Linux' assert
structure. The match, however, was not sufficiently specific as it just
accepted any statement that follows the actual assertion.

Fixes: diffblue#8436
@tautschnig tautschnig merged commit d67648a into diffblue:develop Sep 5, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the fix-8436-conversion branch September 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant violation during goto conversion on C file with goto statements
3 participants