Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define project(CBMC ...) twice to fix CMake failures #8435

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jbmc/regression/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set(test_pl_path "${CBMC_SOURCE_DIR}/../regression/test.pl")
set(test_pl_path "${CBMC_SOURCE_DIR}/regression/test.pl")

# For the best possible utilisation of multiple cores when
# running tests in parallel, it is important that these directories are
Expand Down
2 changes: 1 addition & 1 deletion jbmc/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ macro(generic_includes name)
${JBMC_BINARY_DIR}
${JBMC_SOURCE_DIR}
${CBMC_BINARY_DIR}
${CBMC_SOURCE_DIR}
${CBMC_SOURCE_DIR}/src
${CMAKE_CURRENT_BINARY_DIR}
${CMAKE_CURRENT_SOURCE_DIR}
${CUDD_INCLUDE}
Expand Down
6 changes: 3 additions & 3 deletions jbmc/unit/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
file(GLOB_RECURSE sources "*.cpp" "*.h")
list(APPEND sources ${CBMC_SOURCE_DIR}/../unit/unit_tests.cpp)
list(APPEND sources ${CBMC_SOURCE_DIR}/unit/unit_tests.cpp)

file(GLOB_RECURSE java-testing_utils "java-testing-utils/*.cpp" "java-testing-utils/*.h")

Expand All @@ -14,8 +14,8 @@ add_executable(java-unit ${sources})
target_include_directories(java-unit
PUBLIC
${CBMC_BINARY_DIR}
${CBMC_SOURCE_DIR}
${CBMC_SOURCE_DIR}/../unit
${CBMC_SOURCE_DIR}/src
${CBMC_SOURCE_DIR}/unit
${CMAKE_CURRENT_SOURCE_DIR}
)
target_link_libraries(java-unit
Expand Down
2 changes: 1 addition & 1 deletion jbmc/unit/java-testing-utils/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ target_link_libraries(java-testing-utils
target_include_directories(java-testing-utils
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/..
${CBMC_SOURCE_DIR}/../unit
${CBMC_SOURCE_DIR}/unit
)
4 changes: 2 additions & 2 deletions regression/libcprover-cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ cprover_default_properties(api-binary-driver)
target_include_directories(api-binary-driver
PUBLIC
${CBMC_BINARY_DIR}
${CBMC_SOURCE_DIR}
${CBMC_SOURCE_DIR}/src
# TODO: Should be fixed for the proper include form.
${CMAKE_CURRENT_SOURCE_DIR}/../src/libcprover-cpp/)
target_link_libraries(api-binary-driver goto-programs util langapi ansi-c cprover-api-cpp)

# Enable test running
set(test_pl_path "${CBMC_SOURCE_DIR}/../regression/test.pl")
set(test_pl_path "${CBMC_SOURCE_DIR}/regression/test.pl")

macro(add_test_pl_profile name cmdline flag profile)
add_test(
Expand Down
6 changes: 2 additions & 4 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
project(CBMC VERSION ${CBMC_VERSION})

find_package(BISON REQUIRED)
find_package(FLEX REQUIRED)

Expand Down Expand Up @@ -66,8 +64,8 @@ endmacro(generic_flex)
macro(generic_includes name)
target_include_directories(${name}
PUBLIC
${CBMC_BINARY_DIR}
${CBMC_SOURCE_DIR}
${CBMC_BINARY_DIR}/src
${CBMC_SOURCE_DIR}/src
${CMAKE_CURRENT_BINARY_DIR}
${CMAKE_CURRENT_SOURCE_DIR}
)
Expand Down
16 changes: 8 additions & 8 deletions src/solvers/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ list(REMOVE_ITEM sources

add_library(solvers ${sources})

include("${CBMC_SOURCE_DIR}/../cmake/DownloadProject.cmake")
include("${CBMC_SOURCE_DIR}/cmake/DownloadProject.cmake")

foreach(SOLVER ${sat_impl})
if("${SOLVER}" STREQUAL "minisat2")
Expand All @@ -70,8 +70,8 @@ foreach(SOLVER ${sat_impl})
# to 2 times)
download_project(PROJ minisat2
URL http://ftp.debian.org/debian/pool/main/m/minisat2/minisat2_2.2.1.orig.tar.gz
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/../scripts/minisat-2.2.1-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/../scripts/minisat2_CMakeLists.txt CMakeLists.txt
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/scripts/minisat-2.2.1-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/scripts/minisat2_CMakeLists.txt CMakeLists.txt
URL_MD5 27faa19ee0508660bd6fb7f894646d42
)

Expand Down Expand Up @@ -103,8 +103,8 @@ foreach(SOLVER ${sat_impl})

download_project(PROJ glucose
URL https://github.com/BrunoDutertre/glucose-syrup/archive/0bb2afd3b9baace6981cbb8b4a1c7683c44968b7.tar.gz
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/../scripts/glucose-syrup-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/../scripts/glucose_CMakeLists.txt CMakeLists.txt
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/scripts/glucose-syrup-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/scripts/glucose_CMakeLists.txt CMakeLists.txt
URL_MD5 7c539c62c248b74210aef7414787323a
)

Expand All @@ -122,8 +122,8 @@ foreach(SOLVER ${sat_impl})

download_project(PROJ cadical
URL https://github.com/arminbiere/cadical/archive/rel-2.0.0.tar.gz
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/../scripts/cadical-2.0.0-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/../scripts/cadical_CMakeLists.txt CMakeLists.txt
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/scripts/cadical-2.0.0-patch
COMMAND cmake -E copy ${CBMC_SOURCE_DIR}/scripts/cadical_CMakeLists.txt CMakeLists.txt
COMMAND ./configure
URL_MD5 9fc2a66196b86adceb822a583318cc35
)
Expand All @@ -145,7 +145,7 @@ foreach(SOLVER ${sat_impl})

download_project(PROJ cadical
URL https://github.com/arminbiere/cadical/archive/rel-2.0.0.tar.gz
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/../scripts/cadical-2.0.0-patch
PATCH_COMMAND patch -p1 -i ${CBMC_SOURCE_DIR}/scripts/cadical-2.0.0-patch
COMMAND ./configure
URL_MD5 9fc2a66196b86adceb822a583318cc35
)
Expand Down
6 changes: 3 additions & 3 deletions src/util/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ find_package(Git)
if(GIT_FOUND)
file(WRITE ${CMAKE_BINARY_DIR}/version.cmake
"
file(STRINGS \${CBMC_SOURCE_DIR}/config.inc
file(STRINGS \${SRC}/src/config.inc
config_inc_v REGEX \"CBMC_VERSION *= *[0-9\.]+\")
string(REGEX REPLACE \"^CBMC_VERSION *= *\" \"\" CBMC_RELEASE \${config_inc_v})
execute_process(
Expand All @@ -20,7 +20,7 @@ if(GIT_FOUND)
else()
file(WRITE ${CMAKE_BINARY_DIR}/version.cmake
"
file(STRINGS \${CBMC_SOURCE_DIR}/config.inc
file(STRINGS \${SRC}/src/config.inc
config_inc_v REGEX \"CBMC_VERSION *= *[0-9\.]+\")
string(REGEX REPLACE \"^CBMC_VERSION *= *\" \"\" CBMC_RELEASE \${config_inc_v})
set(GIT_INFO \"n/a\")
Expand All @@ -35,7 +35,7 @@ add_custom_target(
generate_version_cpp
BYPRODUCTS version.cpp
COMMAND ${CMAKE_COMMAND}
-D CBMC_SOURCE_DIR=${CBMC_SOURCE_DIR}
-D SRC=${CBMC_SOURCE_DIR}
-D CUR=${CMAKE_CURRENT_BINARY_DIR}
-P ${CMAKE_BINARY_DIR}/version.cmake
)
Expand Down
2 changes: 1 addition & 1 deletion unit/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ add_executable(unit ${sources})
target_include_directories(unit
PUBLIC
${CBMC_BINARY_DIR}
${CBMC_SOURCE_DIR}
${CBMC_SOURCE_DIR}/src
${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR}
${CUDD_INCLUDE}
Expand Down
2 changes: 1 addition & 1 deletion unit/libcprover-cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ file(GLOB_RECURSE sources "*.cpp" "*.h")
add_executable(lib-unit ${sources})
target_include_directories(lib-unit
PUBLIC
${CBMC_SOURCE_DIR}/libcprover-cpp
${CBMC_SOURCE_DIR}/src/libcprover-cpp
)
target_link_libraries(lib-unit
cprover-api-cpp
Expand Down
Loading