-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string literal support to incremental SMT decision procedure #7808
Add string literal support to incremental SMT decision procedure #7808
Conversation
thomasspriggs
commented
Jul 14, 2023
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7808 +/- ##
===========================================
+ Coverage 78.67% 78.68% +0.01%
===========================================
Files 1699 1699
Lines 194122 194172 +50
===========================================
+ Hits 152719 152791 +72
+ Misses 41403 41381 -22
☔ View full report in Codecov by Sentry. |
@@ -30,6 +30,8 @@ | |||
#include <goto-symex/path_storage.h> | |||
#include <solvers/smt2_incremental/smt_to_smt2_string.h> | |||
|
|||
#include "string_constant.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason CI fails is this needs to be either <util/string_constant.h>
or there must be a string_constant.h
header somewhere else that hasn't been included with this PR.
Either way, an easy fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite likely.
9da18ef
to
3f7e416
Compare