Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string literal support to incremental SMT decision procedure #7808

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

thomasspriggs
Copy link
Collaborator

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (cafe331) 78.67% compared to head (3f7e416) 78.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7808      +/-   ##
===========================================
+ Coverage    78.67%   78.68%   +0.01%     
===========================================
  Files         1699     1699              
  Lines       194122   194172      +50     
===========================================
+ Hits        152719   152791      +72     
+ Misses       41403    41381      -22     
Impacted Files Coverage Δ
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 95.82% <100.00%> (+0.08%) ⬆️
...ncremental/smt2_incremental_decision_procedure.cpp 98.73% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -30,6 +30,8 @@
#include <goto-symex/path_storage.h>
#include <solvers/smt2_incremental/smt_to_smt2_string.h>

#include "string_constant.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason CI fails is this needs to be either <util/string_constant.h> or there must be a string_constant.h header somewhere else that hasn't been included with this PR.

Either way, an easy fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite likely.

@thomasspriggs thomasspriggs merged commit eb20424 into diffblue:develop Jul 18, 2023
34 of 35 checks passed
@thomasspriggs thomasspriggs deleted the tas/smt_string_literals branch July 18, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants