Add missing cleanup #7798
Merged
Add missing cleanup #7798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
cleanup/cleaning
branch
from
ee966f0
to
8e5c33e
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7798 +/- ##
===========================================
- Coverage 78.68% 78.68% -0.01%
===========================================
Files 1699 1699
Lines 194172 194172
===========================================
- Hits 152791 152790 -1
- Misses 41381 41382 +1 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
cleanup/cleaning
branch
8 times, most recently
from
91bdd2a
to
569c28e
Compare
tautschnig
force-pushed
the
cleanup/cleaning
branch
6 times, most recently
from
c59a15a
to
2a1444f
Compare
Ensure both build infrastructures remain in sync.
These tests should also be run when using Makefile-based builds, and Makefiles are the only way to perform cleanup.
Ensure that both CMake and Make run the same set of tests, and facilitate cleanup after running tests (for either build system).
make clean did not actually remove all files. Includes disabling an export-symex-ready-goto test with --xml-ui for check.py will wrap the `""` argument and make the test produce an actual goto binary in a file named `""`.
Make sure "clean" actually does a full cleanup.
tautschnig
force-pushed
the
cleanup/cleaning
branch
from
2a1444f
to
da99314
Compare
tautschnig
requested review from
a team,
NlightNFotis,
thomasspriggs,
esteffin,
TGWDB and
peterschrammel
as code owners
tautschnig
assigned NlightNFotis, esteffin, thomasspriggs, TGWDB, kroening and peterschrammel and unassigned tautschnig
TGWDB
approved these changes
Aug 3, 2023
peterschrammel
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make clean did not actually remove all files.