Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incremental SMT support for struct with and member expressions #7787

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Add incremental SMT support for struct with and member expressions #7787

merged 12 commits into from
Jul 13, 2023

Conversation

thomasspriggs
Copy link
Collaborator

@thomasspriggs thomasspriggs commented Jun 29, 2023 •
edited
Loading

This PR adds incremental SMT support for struct with and member expressions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 98.66% and project coverage change: +0.06 🎉

Comparison is base (da48fba) 78.58% compared to head (c4ccf66) 78.64%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7787      +/-   ##
===========================================
+ Coverage    78.58%   78.64%   +0.06%     
===========================================
  Files         1693     1697       +4     
  Lines       193381   193894     +513     
===========================================
+ Hits        151962   152491     +529     
+ Misses       41419    41403      -16
Impacted Files Coverage Δ
...olvers/smt2_incremental/encoding/struct_encoding.h 100.00% <ø> (ø)
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 95.73% <94.11%> (-0.51%) ⬇️
...vers/smt2_incremental/encoding/struct_encoding.cpp 95.04% <96.96%> (+5.86%) ⬆️
...vers/smt2_incremental/encoding/struct_encoding.cpp 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thomasspriggs
Add extra field to existing test
396549d 
To ensure that following tests have "beginning", "middle" and "end"
fields and so increase the thoroughness of them.
@thomasspriggs
Add encoding of member expressions in new SMT decision procedure
9527c69
@thomasspriggs
Add encoding of with_exprt
5258eba
@thomasspriggs
Refactor get_identifier as member function of decision procedure
2561574 
This already reads large parts of the internal state, so the refactor
cuts down on parameters passed and enables use of other member
functions.
@thomasspriggs
Make get_identifier use complete lowering chain
9909511 
The previous lowering of enums alone prevents this from working as
needed for structs.
@thomasspriggs
Refactor array overload of get_expr
787f76e 
So that the call for getting the index term can more easily be
distinguished from the rest of the expression.
@thomasspriggs
Add support for getting value of array of arrays
384772f 
In preparation for array of struct support.
@thomasspriggs thomasspriggs marked this pull request as ready for review July 11, 2023 16:43
@thomasspriggs thomasspriggs merged commit cafe331 into diffblue:develop Jul 13, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NlightNFotis NlightNFotis NlightNFotis approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB is a code owner

Assignees
No one assigned
Labels
SMT Backend Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasspriggs @NlightNFotis