Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump cosmos-sdk into v0.47.13 #1343

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 8, 2024

Description

Closes: #XXXX

This PR bumps cosmos-sdk into v0.47.13.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features

    • Upgraded Go version from 1.20 to 1.21, enhancing compatibility and available features.
    • Updated several key dependencies, which may introduce important bug fixes and optimizations.
  • Bug Fixes

    • Upgraded dependencies, including cosmos-sdk and cometbft, potentially addressing previous issues and enhancing overall stability.
  • Chores

    • Transitioned from docker-compose to docker compose command syntax in scripts and Makefile for improved compatibility.
    • Modified the subnet configuration in Docker Compose to limit available IP addresses, potentially affecting network resource allocation.

@dadamu dadamu requested a review from a team as a code owner August 8, 2024 07:38
Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Walkthrough

The go.mod file for the github.com/desmos-labs/desmos/v7 module has been updated, featuring a Go version upgrade from 1.20 to 1.21 alongside numerous dependency increments. This maintenance effort enhances compatibility, stability, and access to new features, reflecting best practices in Go development. Additionally, the Makefile and various scripts have transitioned to the newer docker compose command syntax, ensuring alignment with current Docker standards. A subnet size adjustment in the Docker Compose configuration also improves network management.

Changes

File/Module Change Summary
go.mod Updated Go version from 1.20 to 1.21; multiple dependency version upgrades
Makefile, contrib/.../*.sh (grouped) Transitioned from docker-compose to docker compose for local network commands
docker-compose.yml Subnet changed from 192.168.255.0/16 to 192.168.255.0/24

Poem

In the garden of code where we play,
A hop and a skip, we upgrade today!
Dependencies dance, versions align,
Go's new features, oh so divine!
With each little change, our module grows,
A rabbit's joy in the code that flows! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dadamu
Copy link
Contributor Author

dadamu commented Aug 8, 2024

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e5e171f and e6c7788.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (12 hunks)
Additional comments not posted (16)
go.mod (16)

3-3: Verify compatibility with Go 1.21.

Ensure that the codebase is compatible with the new Go version, as it may introduce breaking changes or deprecations.

Verification successful

No deprecated features or breaking changes found with Go 1.21 update.

The update to Go 1.21 does not introduce any deprecated features or breaking changes in the codebase. The note found is related to a planned deprecation within the application itself, not due to the Go update.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any deprecated or breaking changes due to Go 1.21 update.

# Test: Search for deprecated functions or features in the codebase.
rg --type go "deprecated" --glob '!vendor/*'

Length of output: 134


119-119: Verify the reason for go-spew commit update.

Check why github.com/davecgh/go-spew has been updated to a specific commit and ensure it doesn't introduce any issues.

Verification successful

Update to go-spew commit does not introduce functional changes.

The update to the specific commit d8f796af33cc in github.com/davecgh/go-spew only involves a change in the .travis.yml file to add testing against Go 1.11. This does not affect the functionality of the library itself and is unlikely to introduce issues.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the reason for the `go-spew` commit update.

# Test: Check the commit details for changes.
gh api repos/davecgh/go-spew/commits/d8f796af33cc

Length of output: 3817


252-252: Verify the reason for go-difflib commit update.

Check why github.com/pmezard/go-difflib has been updated to a specific commit and ensure it doesn't introduce any issues.

Verification successful

No functional impact from go-difflib commit update

The commit 5d4384ee4fb2 for github.com/pmezard/go-difflib only includes a minor correction in the README example and does not affect the library's functionality. This update should not introduce any issues.

  • The change is limited to documentation and does not impact any code used in production.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the reason for the `go-difflib` commit update.

# Test: Check the commit details for changes.
gh api repos/pmezard/go-difflib/commits/5d4384ee4fb2

Length of output: 5408


190-190: Verify changes in go-getter update.

Review the changes in github.com/hashicorp/go-getter v1.7.5 to ensure there are no breaking changes or issues that could affect the codebase.


135-135: Check changes in fsnotify update.

Review the changes in github.com/fsnotify/fsnotify v1.7.0 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

No breaking changes in fsnotify v1.7.0 update.

The update to github.com/fsnotify/fsnotify v1.7.0 includes several improvements and bug fixes without introducing breaking changes. Ensure that the codebase does not rely on any behavior that might be affected by these updates, particularly if platform-specific features are used.

  • Review any platform-specific implementations that might be impacted by the changes in fsnotify.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `fsnotify` update.

# Test: Check the release notes for changes.
gh release view v1.7.0 --repo github.com/fsnotify/fsnotify

Length of output: 3305


249-249: Verify changes in go-toml update.

Review the changes in github.com/pelletier/go-toml/v2 v2.1.0 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

Dependency Update Verified: go-toml v2.1.0

The update to github.com/pelletier/go-toml/v2 v2.1.0 includes enhancements and bug fixes without any breaking changes. The reintroduction of the commented struct field tag and improved error messages are notable improvements. No issues should arise from this update.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `go-toml` update.

# Test: Check the release notes for changes.
gh release view v2.1.0 --repo github.com/pelletier/go-toml

Length of output: 3876


282-282: Verify changes in afero update.

Review the changes in github.com/spf13/afero v1.11.0 to ensure there are no breaking changes or issues that could affect the codebase.


268-268: Verify changes in slog-shim update.

Review the changes in github.com/sagikazarmark/slog-shim v0.1.0 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

No breaking changes in slog-shim v0.1.0

The update to github.com/sagikazarmark/slog-shim v0.1.0 mainly involves documentation changes to explain backward compatibility. The package acts as a bridge for integrating slog in a backward-compatible way across different Go versions. There are no code changes that introduce breaking changes or affect functionality.

  • The release note highlights how the package maintains backward compatibility with older Go versions while supporting newer features in Go 1.21.
  • No significant code changes were identified that would impact the current usage of this package.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `slog-shim` update.

# Test: Check the release notes for changes.
gh release view v0.1.0 --repo github.com/sagikazarmark/slog-shim

Length of output: 84


Script:

#!/bin/bash
# Description: Check for tags and changes in the `slog-shim` repository related to version v0.1.0.

# Clone the repository to inspect tags and commits.
git clone --quiet https://github.com/sagikazarmark/slog-shim.git

# Navigate into the cloned repository.
cd slog-shim

# List all tags to find v0.1.0.
git tag

# Show the commit details for tag v0.1.0 if it exists.
git show v0.1.0 || echo "Tag v0.1.0 not found"

Length of output: 3072


280-280: Check changes in conc update.

Review the changes in github.com/sourcegraph/conc v0.3.0 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

No direct impact from conc v0.3.0 update detected.

The breaking changes in github.com/sourcegraph/conc v0.3.0, particularly related to pools and panic handling, do not appear to directly affect the current codebase, as no usage of these features was detected. However, consider reviewing any indirect dependencies or related code paths to ensure comprehensive coverage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `conc` update.

# Test: Check the release notes for changes.
gh release view v0.3.0 --repo github.com/sourcegraph/conc

Length of output: 1875


Script:

#!/bin/bash
# Search for usage of `conc` pools in the codebase to check for potential impacts.
rg 'conc\.(ContextPool|ResultContextPool|Pool)' -A 5

# Search for usage of `conc/panics` to check for potential impacts due to renaming and changes.
rg 'conc/panics' -A 5

Length of output: 76


40-40: Check changes in viper update.

Review the changes in github.com/spf13/viper v1.18.2 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

Verify usage of Unmarshal methods and build tags.

Check if the codebase uses the Unmarshal or UnmarshalExact methods from viper and if the viper_bind_struct build tag is set, as these could be impacted by the update.


No impact from viper update to v1.18.2.

The codebase does not use the Unmarshal or UnmarshalExact methods from viper, nor does it set the viper_bind_struct build tag. Thus, the update to v1.18.2 should not affect the existing functionality.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `viper` update.

# Test: Check the release notes for changes.
gh release view v1.18.2 --repo github.com/spf13/viper

Length of output: 1098


Script:

#!/bin/bash
# Search for usage of Unmarshal and UnmarshalExact methods from viper in the codebase
rg 'viper\.(Unmarshal|UnmarshalExact)' -A 2

# Search for any build tags related to viper_bind_struct
rg 'viper_bind_struct'

Length of output: 68


286-286: Check changes in gotenv update.

Review the changes in github.com/subosito/gotenv v1.6.0 to ensure there are no breaking changes or issues that could affect the codebase.


212-212: Check changes in compress update.

Review the changes in github.com/klauspost/compress v1.17.0 to ensure there are no breaking changes or issues that could affect the codebase.

Verification successful

Verify usage of github.com/klauspost/compress in the codebase.

Review the codebase to identify how github.com/klauspost/compress is utilized and ensure that the update to v1.17.0 does not introduce any issues or require changes in the implementation.


No direct impact from compress update.

The update to github.com/klauspost/compress v1.17.0 does not directly affect the codebase as it is an indirect dependency with no direct usage found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `compress` update.

# Test: Check the release notes for changes.
gh release view v1.17.0 --repo github.com/klauspost/compress

Length of output: 2924


Script:

#!/bin/bash
# Search for occurrences of `github.com/klauspost/compress` in the codebase to verify its usage.
rg 'github\.com/klauspost/compress' -A 5

Length of output: 1678


267-267: Check changes in locafero update.

Review the changes in github.com/sagikazarmark/locafero v0.4.0 to ensure there are no breaking changes or issues that could affect the codebase.


16-16: Check release notes for cometbft update.

Review the release notes for github.com/cometbft/cometbft v0.37.5 to ensure that there are no changes that could impact the codebase.


19-19: Review cosmos-sdk update for compatibility.

Ensure that all changes in github.com/cosmos/cosmos-sdk v0.47.13 are compatible with the current codebase and update any affected parts.

Verification successful

Cosmos SDK Update Verified for Compatibility

The update to github.com/cosmos/cosmos-sdk v0.47.13 is primarily a patch release focusing on bug fixes, including a fix for a gRPC query deserialization issue. There are no breaking changes introduced. Ensure that these bug fixes align with your current implementations.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the `cosmos-sdk` update.

# Test: Check the release notes for changes.
gh release view v0.47.13 --repo github.com/cosmos/cosmos-sdk

Length of output: 1239


Script:

#!/bin/bash
# Description: Compare changes between v0.47.12 and v0.47.13 of cosmos-sdk.

# Fetch the changelog for v0.47.13
curl -s https://raw.githubusercontent.com/cosmos/cosmos-sdk/v0.47.13/CHANGELOG.md | grep -A 10 "## [v0.47.13]"

# Compare changes between v0.47.12 and v0.47.13
gh pr list --repo github.com/cosmos/cosmos-sdk --search "base:release/v0.47.x merged:>=2024-07-01" --json number,title,body

Length of output: 14747


18-18: Verify changes in cosmos-proto update.

Check the changes introduced in github.com/cosmos/cosmos-proto v1.0.0-beta.5 to ensure compatibility with the codebase.

@github-actions github-actions bot added the kind/build Related to the build of the project label Aug 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e6c7788 and d383669.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (5)
  • Makefile (1 hunks)
  • contrib/upgrade_testnet/start.sh (1 hunks)
  • contrib/upgrade_testnet/stop.sh (1 hunks)
  • contrib/upgrade_testnet/submit_upgrade_proposal.sh (1 hunks)
  • go.mod (11 hunks)
Files skipped from review due to trivial changes (3)
  • Makefile
  • contrib/upgrade_testnet/start.sh
  • contrib/upgrade_testnet/stop.sh
Additional context used
Shellcheck
contrib/upgrade_testnet/submit_upgrade_proposal.sh

[warning] 108-108: Quote this to prevent word splitting.

(SC2046)

Additional comments not posted (1)
go.mod (1)

Line range hint 2-2: Verify compatibility with Go 1.21.

Ensure that the codebase is compatible with Go 1.21, as this upgrade may introduce breaking changes or require code adjustments.

contrib/upgrade_testnet/submit_upgrade_proposal.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d383669 and 7a1fa68.

Files selected for processing (2)
  • contrib/upgrade_testnet/submit_upgrade_proposal.sh (1 hunks)
  • docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • docker-compose.yml
Files skipped from review as they are similar to previous changes (1)
  • contrib/upgrade_testnet/submit_upgrade_proposal.sh

@dadamu dadamu enabled auto-merge (squash) August 8, 2024 09:16
@dadamu dadamu disabled auto-merge August 8, 2024 09:16
@dadamu dadamu merged commit 55aca17 into master Aug 8, 2024
33 checks passed
@dadamu dadamu deleted the paul/bump-cosmos-sdk-to-0.47.13 branch August 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/build Related to the build of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant