Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix split test files ci #1316

Merged
merged 2 commits into from
Apr 2, 2024
Merged

ci: fix split test files ci #1316

merged 2 commits into from
Apr 2, 2024

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Mar 29, 2024

Description

Closes: #XXXX

This PR fixes the CI of splitting test files, currently, it always fails since it requires go mod tidy to update go.mod before go list.
https://github.com/desmos-labs/desmos/actions/runs/8479093667/job/23232524696?pr=1309#step:3:172


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Chores
    • Enhanced the GitHub workflow by incorporating go mod tidy before listing packages to ensure a tidy module list.
    • Introduced a change in CI for fixing split-test-files CI, ensuring backward compatibility.

@dadamu dadamu requested a review from a team as a code owner March 29, 2024 08:51
Copy link
Contributor

coderabbitai bot commented Mar 29, 2024

Walkthrough

The recent update enhances a GitHub Actions workflow by ensuring that go mod tidy is executed before listing all Go packages in the project. This adjustment aims to clean and tidy up the project's dependencies, making sure the list of packages is accurate and up-to-date.

Changes

File Path Change Summary
.github/workflows/test.yml Modified the run command to include go mod tidy && before listing packages.

🐇✨
In the realm of code, where the rabbits play,
A tidy garden, we've made today.
With a hop and a skip, go mod tidy we run,
Listing packages, one by one.
In workflows and actions, our changes shine,
A testament to a codebase, ever so fine.
🌱📝

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the kind/ci Improve the CI/CD label Mar 29, 2024
@dadamu dadamu added the automerge Automatically merge PR once all prerequisites pass label Mar 29, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bce3217 and e261a46.
Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
Additional Context Used
Additional comments not posted (1)
.github/workflows/test.yml (1)

73-73: The addition of go mod tidy && before go list ./... > pkgs.txt is a good practice to ensure the go.mod file is up-to-date, addressing the CI failure issue effectively. However, it's advisable to monitor the CI job's execution time after this change to ensure it does not introduce significant delays.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e261a46 and 05756cc.
Files selected for processing (1)
  • .changeset/entries/6a2bc0788a319a5b56de4908bf20a27982dbe823977d30fb4cb174621658b2d5.yaml (1 hunks)
Additional Context Used

@dadamu dadamu merged commit 69f86ae into master Apr 2, 2024
35 checks passed
@dadamu dadamu deleted the paul/fix-split-test-files-ci branch April 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/ci Improve the CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants