-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps)!: bump wasmd to 0.41.0 from 0.40.0 #1209
Conversation
// The gov proposal types can be individually enabled | ||
if len(wasmEnabledProposals) != 0 { | ||
govRouter.AddRoute(wasm.RouterKey, wasm.NewWasmProposalHandler(app.WasmKeeper, wasmEnabledProposals)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it since WasmProposalHandler was deprecated, now using gov1 to handle proposals. See:
https://github.com/CosmWasm/wasmd/blob/33df4aeaaa419f6aad07b94d64c0423bee0a2d21/x/wasm/keeper/proposal_handler.go#L19
CosmWasm/wasmd#1246
@@ -179,8 +179,7 @@ type DesmosApp struct { | |||
|
|||
func NewDesmosApp( | |||
logger log.Logger, db dbm.DB, traceStore io.Writer, loadLatest bool, | |||
appOpts servertypes.AppOptions, wasmEnabledProposals []wasm.ProposalType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove wasmEnabledProposals since it is unused in the latest wasmd.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 80.49% 80.49% -0.01%
==========================================
Files 218 218
Lines 18289 18286 -3
==========================================
- Hits 14722 14719 -3
Misses 2955 2955
Partials 612 612
☔ View full report in Codecov by Sentry. |
Description
This PR bumps wasmd to 0.41.0.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change