chore: add proto annotation #1185
Conversation
github-actions
bot
added
x/profiles
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 194 194
Lines 17310 17310
=======================================
Hits 13987 13987
Misses 2727 2727
Partials 596 596 ☔ View full report in Codecov by Sentry. |
| @@ -22,15 +24,23 @@ message Subspace { | |||
| // Optional description of this subspace | |||
| string description = 3 [ (gogoproto.moretags) = "yaml:\"description\"" ]; | |||
|
|
|||
| // Represents the account that is associated with the subspace and | |||
| // should be used to connect external applications to verify this subspace | |||
There was a problem hiding this comment.
Remove it since now no one can use treasury account to sign anything
dadamu
force-pushed
the
paul/add-proto-annotation
branch
from
a2730bb
to
3a40908
Compare
| repeated UserAnswer user_answers = 6 [ (gogoproto.nullable) = false ]; | ||
| Params params = 7 [ (gogoproto.nullable) = false ]; | ||
| repeated PostOwnerTransferRequest post_owner_transfer_requests = 8 [ (gogoproto.nullable) = false ]; | ||
| [ (gogoproto.nullable) = false, (amino.dont_omitempty) = true ]; |
There was a problem hiding this comment.
Cosmos-SDK adds amino annotation inside genesis files as well.
https://github.com/cosmos/cosmos-sdk/blob/ab77fe20d3c00ef4cb73dfd0c803c4593a3c8233/proto/cosmos/bank/v1beta1/genesis.proto#L15
But, I think genesis is not needed to support Amino. What do you think? @RiccardoM
There was a problem hiding this comment.
Asked the question inside Cosmos Discord:
https://discord.com/channels/669268347736686612/1125308043102531646
There was a problem hiding this comment.
I agree it should not be added to the genesis file. However, we can keep it for now as it's only metadata that does not truly affect anything to be honest.
| repeated Post posts = 1 | ||
| [ (gogoproto.nullable) = false, (amino.dont_omitempty) = true ]; |
|
@dadamu Is this PR ready to be reviewed? If so can you mark it as such instead of Draft? |
|
@RiccardoM Yes, it is ready to review. Turned it. |
Description
This PR adds useful proto annotation for upcoming feature cosmos/cosmos-sdk#13310, which supports the auto command line tool generation.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change