refactor(tests): improve x/reports tests using gomock #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadamu
force-pushed
the
paul/improve-report-gomock
branch
from
42902b9
to
0660513
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
=======================================
Coverage 80.79% 80.80%
=======================================
Files 194 194
Lines 17310 17310
=======================================
+ Hits 13986 13987 +1
Misses 2727 2727
+ Partials 597 596 -1
☔ View full report in Codecov by Sentry. |
dadamu
force-pushed
the
paul/improve-report-gomock
branch
2 times, most recently
from
f102338
to
a89646c
Compare
RiccardoM
reviewed
Jun 26, 2023
Comment on lines
+47
to
+55
|
|
||
| // Delete the reason id key | ||
| h.k.DeleteNextReasonID(ctx, subspaceID) | ||
|
|
||
| // Delete all the reasons related to this subspace | ||
| h.k.IterateSubspaceReasons(ctx, subspaceID, func(reason types.Reason) (stop bool) { | ||
| h.k.DeleteReason(ctx, reason.SubspaceID, reason.ID) | ||
| return false | ||
| }) |
There was a problem hiding this comment.
Why was this code moved here instead of keeping it above?
There was a problem hiding this comment.
DeleteReason also deletes reports containing reasons here, but it causes O(N) since it iterates all the reports when removing a reason, as a result, it makes AfterSubspaceDeleted has O(N^2) time complexity.
Moving this code above can have better performance with O(2N) time complexity since reports containing reasons are removed first.
RiccardoM
approved these changes
Jun 26, 2023
RiccardoM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the x/reports tests using gomock.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change