Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve & use the new FlagsEditor for all flags #121

Merged
merged 3 commits into from
May 12, 2024
Merged

Improve & use the new FlagsEditor for all flags #121

merged 3 commits into from
May 12, 2024

Commits on May 11, 2024

  1. Non-generic FlagsConverter

    @ahmetsait
    ahmetsait committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0132db8 View commit details
    Browse the repository at this point in the history

  2. 64-bit enum support for FlagsEnumConverter

    @ahmetsait
    ahmetsait committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ec5df98 View commit details
    Browse the repository at this point in the history

  3. Improve & use the new FlagsEditor for all flags 

    Turns out Scintilla had a custom editor for flags called `FlagsEnumConverter` before. Unaware of the first one, I wrote a new one called `FlagsEditor` for `ChangeHistory` enum. I may be biased but it turned out pretty good so I think it would be cool to use it for all flags.
    @ahmetsait
    ahmetsait committed May 11, 2024
    Configuration menu
    Copy the full SHA
    158144d View commit details
    Browse the repository at this point in the history