-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use custom base64 decoder to workaround deno bug #406
Open
markwylde
wants to merge
5
commits into
denodrivers:main
Choose a base branch
from
markwylde:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c8cde3
fix: use custom base64 decoder to workaround deno bug
markwylde e7e45bd
fix: move decodeBase64 to utils and remove atob usage
markwylde 781df1a
fix: match style of existing codebase
markwylde 059cce8
fix: remove demo folder
markwylde 25b1b3c
fix: lint
markwylde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are converting a URL Safe base64 to an actual base64?
so you issue is that you don't actually use a base64 string, but you use a url safe base64 adoptation.
base64 uses / and + by default. so the current impl is not wrong. we just expect actual base64 strings
do you require a url safe base64? / is this per mongodb driver spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a really good question lucsoft, but I don't have the answers unfortunately.
I have managed to create a small script to recreate the problem:
Run that, and within a few seconds it will throw:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure what's going on, but if I edit the
scram.ts
fileThen run my script above, I get:
It's strange, the ones before have a blank parsedResponse, seem to work. But when data get's returned it fails. What is that data?