Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Message-timestamp-updating #2270

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Update Message-timestamp-updating #2270

merged 3 commits into from
Aug 21, 2024

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Aug 19, 2024 •
edited
Loading

  • Timer moved from ChatViewController to BaseMessageCell: There's no need to reload the entire table just to update a label.
  • Timer doesn't get stopped when app gets sent to background or restarted when app returns to foreground, they just continue to run once per minute updating the labels
  • Closes message bubble timestamp sometimes updated too late #2220.

@zeitschlag
Remove Timer from ChatViewController (#2220)
52c324e
@zeitschlag
Move timer to cell (#2220)
e0838a8 
As the timestamp never changes, I don't see the need to reload the entire tableView if it's sufficient to update the Timestamp-Label
@zeitschlag
Rename bottomLabel to statusView (#2220)
a0bd469 
It contains more than just a label, naming's hard :D
@zeitschlag zeitschlag changed the title Update Message-timestamp Update Message-timestamp-updating Aug 19, 2024
@zeitschlag zeitschlag marked this pull request as ready for review August 19, 2024 14:33
@zeitschlag zeitschlag self-assigned this Aug 19, 2024
@zeitschlag zeitschlag requested a review from r10s August 20, 2024 08:38
r10s
r10s approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very elegant, removed lines, less complexity and even faster 👌

@zeitschlag zeitschlag merged commit 13cbb37 into main Aug 21, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2220-refactor-timestamp-timer branch August 21, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees

@zeitschlag zeitschlag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

message bubble timestamp sometimes updated too late
2 participants
@zeitschlag @r10s