Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark bots as such, improve chat-deletion confirmation #2264

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Aug 9, 2024

this PR brings two recent, minor android tweak to iOS:

@r10s r10s added the enhancement actually in development, user visible enhancement label Aug 10, 2024
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

What's the reason for these two changes (that, at least from my perspective, are independent from each other) come in one PR?
Usually I'd have expected two changes to be two seperate PRs.

deltachat-ios/Controller/ChatListViewController.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag added this to the Next Release milestone Aug 11, 2024
@r10s
Copy link
Member Author

r10s commented Aug 11, 2024

shame on me, i agree totally, it should have been two PRs

@r10s r10s merged commit ae56b52 into main Aug 11, 2024
1 check passed
@r10s r10s deleted the r10s/tweak-wordings branch August 11, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants