Scroll to bottom (#2260) #2261
Merged
Scroll to bottom (#2260) #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Cleanup
zeitschlag
force-pushed
the
2260-scroll-down
branch
from
576f753
to
da0987b
Compare
r10s
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The culprit was
let numberOfRows = self.tableView.numberOfRows(inSection: 0)it seems. (My educated guess is thattableViewwasn't ready.) From now on it checks formessageIds.countAlso: Cleanup (some
selfhere, but not there, but for incoming message the same happens as for outgoing messages)Closes #2260.