Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set backward verification when observing vc-contact-confirm or vg-member-added #5930

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Aug 30, 2024

Documentation comment says forward and backward verification is set,
but the code was not doing it.
vc-contact-confirm and vg-member-added messages
indicate that other device finished securejoin protocol
so we know Bob has our key marked as verified.

Related to #5929

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 30, 2024

There are also unrelated bugs with synchronization.

Second Alice's device logs src/sync.rs:303: Ignoring token for nonexistent/deleted group 'IiHMYbcrF7S'. because by the time QR code is generated group is not promoted. Maybe it is fine, only one device processing join requests is not critical. Second device actually does not have group name and avatar so it cannot properly process join requests.

As the QR code is unknown to Alice's second device, when it receives vg-request-with-auth it logs src/securejoin.rs:697: StockMessage::ContactNotVerified posted to 1:1 chat (Auth invalid.). This actually happens even before receiving a sync message because in the test Bob scans Alice's QR code faster than Alice sends a sync message. Posted message "Cannot establish guaranteed end-to-end encryption with ..." is annoying and should not be posted on Alice's side just because it sees message from Bob with unknown AUTH code. Probably should just be ignored. It is Bob who wants to establish contact, Alice should not receive non-actionable error messages.

I opened a separate issue for this: #5932

@link2xt link2xt self-assigned this Aug 30, 2024
@link2xt link2xt requested a review from Hocuri August 30, 2024 03:47
@link2xt link2xt changed the title test: test observing securejoin fix: set backward verification when observing vc-contact-confirm or vg-member-added Aug 30, 2024
@link2xt link2xt force-pushed the link2xt/test-online-observe-securejoin branch from 73a28da to 5d026e8 Compare August 30, 2024 03:48
@link2xt link2xt requested a review from iequidoo August 30, 2024 03:51
… `vg-member-added`

Documentation comment says forward and backward verification is set,
but the code was not doing it.
`vc-contact-confirm` and `vg-member-added` messages
indicate that other device finished securejoin protocol
so we know Bob has our key marked as verified.
@link2xt link2xt force-pushed the link2xt/test-online-observe-securejoin branch from 5d026e8 to 5c3a526 Compare August 30, 2024 04:05
@link2xt link2xt changed the base branch from main to stable August 30, 2024 04:05
@link2xt
Copy link
Collaborator Author

link2xt commented Aug 30, 2024

Based it on stable. Unfortunately, will have to make 1.142.11.

src/securejoin.rs Outdated Show resolved Hide resolved
@link2xt link2xt merged commit d344cc3 into stable Aug 30, 2024
36 checks passed
@link2xt link2xt deleted the link2xt/test-online-observe-securejoin branch August 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"This message was sent with non-verified encryption. See 'Info' for more details."
2 participants