Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update NDK to r27 #3229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update NDK to r27 #3229

wants to merge 1 commit into from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Aug 12, 2024

If we are dropping Android 4 support anyway,
can as well upgrade to the current LTS NDK
which requires API level 21 (Android 5.0).

@link2xt
Copy link
Contributor Author

link2xt commented Aug 12, 2024

Let's not merge for now, maybe we even can restore Android 4 support. There is no urgent need to upgrade and need to check F-Droid build again if we do.

@link2xt
Copy link
Contributor Author

link2xt commented Aug 12, 2024

Built and installed this, seems to work.

@adbenitez
Copy link
Member

I just lowered the support to 19 (android 4.4)

@@ -7,57 +7,6 @@
#include "deltachat-core-rust/deltachat-ffi/deltachat.h"


#if __ANDROID_API__ == 16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One advantage of dropping these Android 16 hacks is that we may be able to get rid of C code completely: https://openjdk.org/jeps/389

@link2xt link2xt self-assigned this Aug 12, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Base automatically changed from adb/issue-1791 to main August 14, 2024 10:24
@link2xt link2xt marked this pull request as ready for review August 14, 2024 18:37
@link2xt link2xt requested review from adbenitez and r10s and removed request for adbenitez August 14, 2024 19:02
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt
Copy link
Contributor Author

link2xt commented Aug 14, 2024

Since we use minSdk 21 now, can also merge this. And then tag a release and reenable F-Droid builds with r27 NDK.

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s added the PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Aug 19, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

If we are dropping Android 4 support anyway,
can as well upgrade to the current LTS NDK
which requires API level 21 (Android 5.0).
Copy link

github-actions bot commented Sep 2, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants