Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idrac_secure_boot]: Attributes, Reset Keys and Export secure boot certificates #727

Conversation

ABHISHEK-SINHA10
Copy link
Collaborator

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 commented Sep 3, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

ABHISHEK-SINHA10 and others added 2 commits September 3, 2024 15:31
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.59690% with 16 lines in your changes missing coverage. Please review.

Project coverage is 93.34%. Comparing base (f5b7288) to head (312ead8).

Files with missing lines Patch % Lines
plugins/modules/idrac_secure_boot.py 83.78% 8 Missing and 4 partials ⚠️
plugins/module_utils/utils.py 80.00% 2 Missing and 1 partial ⚠️
...sts/unit/plugins/modules/test_idrac_secure_boot.py 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           collections     #727      +/-   ##
===============================================
- Coverage        93.36%   93.34%   -0.03%     
===============================================
  Files              207      207              
  Lines            37237    37361     +124     
  Branches          5591     5611      +20     
===============================================
+ Hits             34767    34875     +108     
- Misses            1496     1507      +11     
- Partials           974      979       +5     
Flag Coverage Δ
units 93.34% <87.59%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 added this to the v9.7.0 milestone Sep 4, 2024
@sachin-apa
Copy link
Collaborator

run e2e

Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
singh-lovepreet1 and others added 4 commits September 12, 2024 09:37
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Copy link
Collaborator

@Saksham-Nautiyal Saksham-Nautiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation completed for export.

@Saksham-Nautiyal Saksham-Nautiyal added validation/completed Validation is completed validation/in-progress Validation is in progress and removed validation/in-progress Validation is in progress validation/completed Validation is completed labels Sep 16, 2024
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Copy link
Collaborator

@reetivel reetivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
playbooks/idrac/idrac_secure_boot.yml Outdated Show resolved Hide resolved
playbooks/idrac/idrac_secure_boot.yml Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
docs/modules/idrac_secure_boot.rst Outdated Show resolved Hide resolved
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
rajshekarp87
rajshekarp87 previously approved these changes Sep 20, 2024
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@rajshekarp87 rajshekarp87 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Sep 20, 2024
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 merged commit c077628 into dell:collections Sep 20, 2024
30 checks passed
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 deleted the feature/idrac_secure_boot_export_operation branch September 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants