Update Proof Gen #288
Merged
Update Proof Gen #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christianpaquin, @Wind4Greg ^these are breaking changes for the proof gen. Have included test vectors with additional traces to hopefully help with updating 🙏 |
BasileiosKal
force-pushed
the
vasilis/cdl-proof
branch
from
c07c227
to
9eb25ed
Compare
@BasileiosKal, I updated my implementation (here); test vectors pass. |
christianpaquin
approved these changes
Nov 8, 2023
Wind4Greg
approved these changes
Nov 20, 2023
andrewwhitehead
approved these changes
Dec 4, 2023
|
Multiple approvals! Discussed on WG call at the 4th of December. Test Vectors cross validated. Merging. Thank you everyone for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the WG discussions, update the BBS Proof based on [CDL16].
(Uses #287)