Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-parser: Set missing field's collate to table's collate #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaaf
Copy link

@gaaf gaaf commented Mar 29, 2024

Newer MariaDB exports don't set the field's collate if it is the same as the table's collate. To prevent huge diffs between exports of the old and new version, set missing field's collate to the table's collate.

The table's option parsing is moved up so the collate can be extracted before parsing all the fields.

There might be a similar issue with the charset, but I haven't seen that with my datasets.

Newer MariaDB exports don;t set the field's collate if it is the same a
the table's collate. To prevent huge diffs between exports of the old and
new version, set missing field's collate to the table's collate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant