Hashref bind values in insert() no longer cause a warning #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build fail wasn't my fault, tests pass, there's just a problem with Codecov. |
dbsrgits-sync
force-pushed
the
master
branch
2 times, most recently
from
cd96b8a
to
d291f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple change. When this warning was added 11 years ago we didn't know relational databases would be using JSON in 2019. But now we do know there are very valid use cases for hashrefs in bind values. The feature is already used in Mojo::Pg, and judging by discussions on IRC there are plans to have native support for JSON in
DBD::Pgat some point in the future. So i believe this deprecation should be reverted.