enable CI for the ROS2 branch #140
Conversation
|
Please do not modify the content of the vectornav library. This is a copy of the upstream library and when updates occur, we want to be able to replace the library and look at the diff to easily see what changed. |
|
This is awesome otherwise tho!! I hope you can figure out how to bypass that directory. |
|
I'm not sure there is any way to skip that directory. I tried for hours and ran out of ideas.
|
|
The upstream source is behind a login / eula. I got special permission to
redistribute it here for ROS users.
…On Tue, Jun 25, 2024, 6:11 PM Bernd Pfrommer ***@***.***> wrote:
I'm not sure there is any way to skip that directory. I tried for hours
and ran out of ideas.
But the question is if it needs to be there in the first place. The usual
ways of dealing with such libraries are:
1. Create a ROS "vendor" package (e.g. ros-rolling-vnproglib-vendor)
upon which the driver then depends
2. Alternatively, use CMake's fetch_content() mechanism to download
the desired version of vnproglib on the fly and build/install it along with
the driver
Where are the upstream sources for vnproglib located?
—
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHVF4MP5TTC5X72XELPDLZJHTIZAVCNFSM6AAAAABJOWW3TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGA2TQOBZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Would you be willing to put the library into a separate, clean github repo so the driver can use it from there? |
|
Let me look into it, will take me some time to get some time to chew on it
…On Tue, Jun 25, 2024, 6:24 PM Bernd Pfrommer ***@***.***> wrote:
Would you be willing to put the library into a separate, clean github repo
so the driver can use it from there?
—
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHVFZLNVBTM46JOUTSQWTZJHU3FAVCNFSM6AAAAABJOWW3TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGEYDANBTGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
If you want to I can also prepare a repo and transfer ownership to you once done. |
|
@dawonn let me contact vectornav to see if I can make a vnproglib vendor package for ROS2. I think that would be the cleanest solution. |
|
Got a reply from Vectornav saying that they are updating the SDK and will release a ROS2 driver with it! |
|
Very cool!
…On Wed, Aug 7, 2024, 11:58 AM Bernd Pfrommer ***@***.***> wrote:
Got a reply from Vectornav saying that they are updating the SDK and will
release a ROS2 driver with it!
—
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHVF7E2XFAOOSZAB3WAQDZQI73PAVCNFSM6AAAAABJOWW3TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTHAYDONJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR enables Continuous Integration testing for the ROS2 branch.
Unfortunately I was unable to get clang-format to skip the vnproglib directory. I tried for hours and eventually gave up and reformatted the vnproglib directory.
Generally cosmetic changes are to be strictly avoided, but AFAICT right now there is no coding standard set or enforced, and that is also sub optimal. Right now there are no outstanding PRs, so this is as good a time as any to make such drastic changes to the code base.
I prefer clang-format over uncrustify because uncrustify in some cases reformats code so cpplint croaks.
This PR makes no changes to the logic of the driver code.