Add sub-extension to resource files in built-in templates #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yml file extension
shreyas-goenka
requested review from
pietern,
andrewnester and
lennartkats-db
and removed request for
pietern,
andrewnester and
lennartkats-db
shreyas-goenka
requested review from
lennartkats-db,
pietern and
andrewnester
and removed request for
lennartkats-db
pietern
changed the title
|
@shreyas-goenka Can you update the PR summary? Change LGTM. |
|
@pietern I have updated the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We want to encourage a pattern of only specifying a single resource in a YAML file when an
.<resource-type>.yml(like.job.yml) is used. This convention could allow us to bijectively map a resource YAML file to it's corresponding resource in the Databricks workspace.This PR simply makes the built-in templates compliant to this format.
Tests
Existing tests.