Skip to content

Commit

Permalink
Converted library augmentations into parts in analyzer/ tests.
Browse files Browse the repository at this point in the history
Change-Id: I91ad3b6fb5fd4c785a1eb99e182c4e16525dd0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
  • Loading branch information
fshcheglov authored and Commit Queue committed Aug 29, 2024
1 parent 04f3e7a commit ed53041
Show file tree
Hide file tree
Showing 52 changed files with 833 additions and 833 deletions.
8 changes: 4 additions & 4 deletions pkg/analyzer/test/src/dart/analysis/search_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -819,15 +819,15 @@ self::@class::C::@method::main

test_searchReferences_class_constructor_declaredInAugmentation() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart';
part of 'test.dart';
augment class A {
A.named();
}
''');

await resolveTestCode('''
import augment 'a.dart';
part 'a.dart';
class A {
void foo() {
Expand All @@ -846,9 +846,9 @@ void f() {

await assertElementReferencesText(element, r'''
self::@class::A::@method::foo
56 5:6 |.named| INVOCATION qualified
46 5:6 |.named| INVOCATION qualified
self::@function::f
87 10:4 |.named| INVOCATION qualified
77 10:4 |.named| INVOCATION qualified
''');
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/analyzer/test/src/dart/analysis/session_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -767,13 +767,13 @@ class B {}

test_getUnitElement_augmentationKnown_inLibrary() async {
var a = newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart';
part of 'test.dart';
class A {}
class B {}
''');

newFile(testFile.path, r'''
import augment 'a.dart';
part 'a.dart';
''');

await _assertFileUnitElementResultText(a, r'''
Expand Down
24 changes: 12 additions & 12 deletions pkg/analyzer/test/src/dart/element/element_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1654,14 +1654,14 @@ class A {

test_lookUpGetter_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
int get g {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part 'a.dart';
class A {}
''');
Expand All @@ -1687,14 +1687,14 @@ class B extends A {}

test_lookUpGetter_inherited_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
int get g {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part 'a.dart';
class A {}
class B extends A {}
Expand Down Expand Up @@ -1751,14 +1751,14 @@ class A {

test_lookUpMethod_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
int m() {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part 'a.dart';
class A {}
''');
Expand All @@ -1784,14 +1784,14 @@ class B extends A {}

test_lookUpMethod_inherited_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
int m() {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part'a.dart';
class A {}
class B extends A {}
Expand Down Expand Up @@ -1848,14 +1848,14 @@ class A {

test_lookUpSetter_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
set s(x) {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part 'a.dart';
class A {}
''');
Expand All @@ -1881,14 +1881,14 @@ class B extends A {}

test_lookUpSetter_inherited_fromAugmentation() async {
newFile('$testPackageLibPath/a.dart', '''
augment library 'test.dart';
part of 'test.dart';
augment class A {
set s(x) {}
}
''');
var library = await buildLibrary('''
import augment 'a.dart';
part 'a.dart';
class A {}
class B extends A {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,7 @@ conflicts

test_interface_candidatesConflict_interfaceInAugmentation() async {
var a = newFile('$testPackageLibPath/a.dart', r'''
import augment 'b.dart';
part 'b.dart';
mixin A {
void foo(int _);
Expand All @@ -1450,7 +1450,7 @@ abstract class C extends Object with A {}
''');

newFile('$testPackageLibPath/b.dart', r'''
augment library 'a.dart';
part of 'a.dart';
augment abstract class C implements B {}
''');
Expand Down
36 changes: 18 additions & 18 deletions pkg/analyzer/test/src/dart/resolution/assignment_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1617,23 +1617,23 @@ AssignmentExpression

test_prefixedIdentifier_ofClass_getterAugmentationDeclares() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
int get foo => 0;
}
''');

await assertErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {}
void f(A a) {
a.foo = 0;
}
''', [
error(CompileTimeErrorCode.ASSIGNMENT_TO_FINAL_NO_SETTER, 56, 3),
error(CompileTimeErrorCode.ASSIGNMENT_TO_FINAL_NO_SETTER, 46, 3),
]);

var node = findNode.singleAssignmentExpression;
Expand Down Expand Up @@ -1667,14 +1667,14 @@ AssignmentExpression

test_prefixedIdentifier_ofClass_setterAugmentationAugments() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
augment set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {
set foo(int _) {}
Expand Down Expand Up @@ -1716,14 +1716,14 @@ AssignmentExpression

test_prefixedIdentifier_ofClass_setterAugmentationDeclares() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {}
Expand Down Expand Up @@ -1763,23 +1763,23 @@ AssignmentExpression

test_prefixedIdentifier_ofClassName_getterAugmentationDeclares() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
static int get foo => 0;
}
''');

await assertErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {}
void f() {
A.foo = 0;
}
''', [
error(CompileTimeErrorCode.ASSIGNMENT_TO_FINAL_NO_SETTER, 53, 3),
error(CompileTimeErrorCode.ASSIGNMENT_TO_FINAL_NO_SETTER, 43, 3),
]);

var node = findNode.singleAssignmentExpression;
Expand Down Expand Up @@ -1813,14 +1813,14 @@ AssignmentExpression

test_prefixedIdentifier_ofClassName_setterAugmentationAugments() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
augment static set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {
static set foo(int _) {}
Expand Down Expand Up @@ -1862,14 +1862,14 @@ AssignmentExpression

test_prefixedIdentifier_ofClassName_setterAugmentationDeclares() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
static set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {}
Expand Down Expand Up @@ -2522,14 +2522,14 @@ AssignmentExpression

test_propertyAccess_ofClass_setterAugmentationAugments() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
augment set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {
set foo(int _) {}
Expand Down Expand Up @@ -2574,14 +2574,14 @@ AssignmentExpression

test_propertyAccess_ofClass_setterAugmentationDeclares() async {
newFile('$testPackageLibPath/a.dart', r'''
augment library 'test.dart'
part of 'test.dart'
augment class A {
set foo(int _) {}
}
''');
await assertNoErrorsInCode(r'''
import augment 'a.dart';
part 'a.dart';
class A {}
Expand Down
Loading

0 comments on commit ed53041

Please sign in to comment.