Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package:http_profile] Store request and response bodies in the backing map as lists instead of as streams #1154
[package:http_profile] Store request and response bodies in the backing map as lists instead of as streams #1154
Changes from all commits
bb1f7a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was incorrect before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked before because we were awaiting
_body.stream.expand(...).toList(...)
on the SDK side, so it was impossible for this unawaitedbodySink.close()
to cause the'requestBody'
or'responseBody'
entries to get populated incorrectly here (https://github.com/dart-lang/sdk/blob/9efa95674966c1d8b498c1846372f36db689f8c7/sdk/lib/io/network_profiling.dart#L34-L44).With the changes in this PR, we need to await
bodySink.close()
to guarantee that all the bytes that have been added to the sink have also been added to_data['requestBodyBytes']
before the SDK tries to read_data['requestBodyBytes']
.http/pkgs/http_profile/lib/src/http_client_request_profile.dart
Lines 81 to 83 in bb1f7a8