Added fallback icon in case of broken link #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature requested in #113, but it never got merged into main and there are conflicts. Do you have cycles to resolve the conflicts? Also, what do you think would be a good way to notify of the error? |
|
Currently experiencing an infinite re-render when the link is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi czeckd!
Please find a attached a proposal for a implementation of a fallback icon in case the icon url is broken. As I found myself the component dispatching a global exception that can't be handled in a local level.
Sorry for the style changes applied by my IDE, using the flag w=1 should make fairly easy to find the real changes, and also it may need some auto-format from your side.
Let me know if you find this useful or you have any suggestion.
thanks!!
J =)