Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Top-down extractor for rewrites #8694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds a top-down extractor for e-graphs in addition to the previously used bottom-up extractor. This allows extracting nodes from e-classes with respect to their state. Use flag CUBESQL_TOP_DOWN_EXTRACTOR=true to enable.

@MazterQyou MazterQyou requested review from a team as code owners September 11, 2024 11:48
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 87.84404% with 53 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (2bb9aa3) to head (157ad9f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 88.03% 42 Missing ⚠️
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 66.66% 8 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8694      +/-   ##
==========================================
- Coverage   82.67%   82.61%   -0.07%     
==========================================
  Files         217      217              
  Lines       78125    78399     +274     
==========================================
+ Hits        64588    64767     +179     
- Misses      13537    13632      +95     
Flag Coverage Δ
cubesql 82.61% <87.84%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 1:42pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant