chore: tsconfig - target es2022 (Node.js 18)

cube-js · Sep 12, 2024 · 8432069 · 8432069
1 parent 678a13a
commit 8432069
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 13 deletions.
diff --git a/packages/cubejs-firebolt-driver/src/FireboltQuery.ts b/packages/cubejs-firebolt-driver/src/FireboltQuery.ts
@@ -1,4 +1,4 @@
-import { BaseFilter, BaseQuery, ParamAllocator } from '@cubejs-backend/schema-compiler';
+import { BaseFilter, BaseQuery } from '@cubejs-backend/schema-compiler';
 
 const GRANULARITY_TO_INTERVAL: Record<string, string> = {
   day: 'DAY',
@@ -22,8 +22,6 @@ class FireboltFilter extends BaseFilter {
 }
 
 export class FireboltQuery extends BaseQuery {
-  public paramAllocator!: ParamAllocator;
-
   public convertTz(field: string) {
     return `${field} AT TIME ZONE '${this.timezone}'`;
   }

diff --git a/packages/cubejs-query-orchestrator/src/orchestrator/LocalQueueEventsBus.ts b/packages/cubejs-query-orchestrator/src/orchestrator/LocalQueueEventsBus.ts
@@ -1,8 +1,6 @@
 import { BaseQueueEventsBus } from './BaseQueueEventsBus';
 
 export class LocalQueueEventsBus extends BaseQueueEventsBus {
-  protected readonly subscribers: Record<string, any>;
-
   public emit(event) {
     Promise.all(Object.values(this.subscribers).map(({ callback }) => callback(event)))
       .catch(err => console.error(err));

diff --git a/packages/cubejs-server-core/test/unit/OptsHandler.test.ts b/packages/cubejs-server-core/test/unit/OptsHandler.test.ts
@@ -17,13 +17,13 @@ import { CubejsServerCore } from '../../src/core/server';
 import { CreateOptions, SystemOptions } from '../../src/core/types';
 
 class CubejsServerCoreExposed extends CubejsServerCore {
-  public options: ServerCoreInitializedOptions;
+  public options: ServerCoreInitializedOptions = super.options;
 
-  public optsHandler: OptsHandler;
+  public optsHandler: OptsHandler = super.optsHandler;
 
-  public contextToDbType: DbTypeAsyncFn;
+  public contextToDbType: DbTypeAsyncFn = super.contextToDbType;
 
-  public contextToExternalDbType: ExternalDbTypeFn;
+  public contextToExternalDbType: ExternalDbTypeFn = super.contextToExternalDbType;
 
   public apiGateway = super.apiGateway;
 

diff --git a/packages/cubejs-server-core/test/unit/index.test.ts b/packages/cubejs-server-core/test/unit/index.test.ts
@@ -14,9 +14,9 @@ import { OrchestratorApiOptions } from '../../src/core/OrchestratorApi';
 
 // It's just a mock to open protected methods
 class CubejsServerCoreOpen extends CubejsServerCore {
-  public readonly optsHandler: OptsHandler;
+  public readonly optsHandler: OptsHandler = super.optsHandler;
 
-  public readonly options: ServerCoreInitializedOptions;
+  public readonly options: ServerCoreInitializedOptions = super.options;
 
   public getRefreshScheduler = super.getRefreshScheduler;
 

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -1,13 +1,14 @@
 {
+  "_version": "18.2.0",
   "exclude": [
     "node_modules",
     "dist",
   ],
   "files": [],
   "compilerOptions": {
     "incremental": true,
-    "lib": ["es2021"],
-    "target": "es2021",
+    "lib": ["es2023"],
+    "target": "es2022",
     "module": "commonjs",
     "baseUrl": ".",
     "paths": {