Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#26) feat: add shellcheck in workflows #27

Merged
merged 1 commit into from
Jul 23, 2023
Merged

(#26) feat: add shellcheck in workflows #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,21 @@ env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

jobs:
shellcheck:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update some checking in the workflow

name: Shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Run ShellCheck
uses: ludeeus/action-shellcheck@master
with:
ignore_paths: >-
sources

push_to_registry:
if: github.event_name != 'pull_request'
name: LAMP Docker Image to Hub
needs: shellcheck
runs-on: ubuntu-latest
steps:
- name: Checkout repository
Expand Down