Feat/merge upstream awsprovider update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass node metadata options to EKS nodes * Fixed metadata_options block in EKS node templates * metadata_options var deafults to empty map * metadata_options var fixed type * Allow EBS volume encryption in odc_eks * Fixed odc_eks variables * Encrypt spot volumes in odc_eks * Validate node metadata_options * Fixed typo in metadata_options variable * Updated readme for odc_eks node options * terraform fmt updates
Clients will need to update their Terraform state manually using the following commands: ```bash terraform state rm module.odc_eks.module.vpc[0].aws_vpc_endpoint_route_table_association.private_s3 terraform state rm module.odc_eks.module.vpc[0].aws_vpc_endpoint_route_table_association.public_s3 ``` See Terraform AWS VPC module upgrade instructions at https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/fbd4ff646b4caaa6fcc1fb71bc88d377cc8b3b48/UPGRADE-3.0.md?plain=1#L25.
…m_update Cluster node iam update
…args Remove --cloud-provider kubelet arg
EKS supports access configuration via two methods: a config map, and an API resource. The old config map style is a bit messy (split across terraform stages, that info needs to propagate across e.g. for enabling fargate, and prone to unvalidated errors). This change enables progressive migration to aws_eks_access_entry resources.
Enable EKS API access config
Updates for AWS provider v5
Fix a simple terraform error
…missions_fix Restore previous cluster-auth behaviour
…ancements Feature/vpc enhancements
…admin_permissions Fix for admin_permissions trying to recreate clusters
squireg
reviewed
Oct 1, 2024
There was a problem hiding this comment.
@woodcockr this change is already in easi-main and our prod branches. I don't understand why it's showing up as a change here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs will require running
terraform fmt -recursivesuccessfully first. Please install terraform version >v0.15on your local setup for this activity.Why this change is needed
Negative effects of this change