fix: Replace all @chakra/* dependencies with @chakra-ui/react + remove unnecessary react imports
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csandman
commented
Jun 29, 2024
| "esModuleInterop": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "downlevelIteration": true, | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
It was necessary to add this in order to prevent Chakra UI from causing the tsc to fail. Not an ideal solution.
csandman
commented
Jul 1, 2024
| @@ -39,28 +39,16 @@ | |||
| "start": "nodemon --watch src --exec npm run build -e ts,tsx" | |||
| }, | |||
| "dependencies": { | |||
| "react-select": "5.8.0" | |||
| "react-select": "5.8.x" | |||
There was a problem hiding this comment.
I realized I don't need to be so strict as to not allow other patch versions of react-select, so this just opens it up for the others.
📊 Package size report -3.09%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a lot of back and forth on whether this package should use
@chakra-ui/reactas it's peer dependency, or just the individual sub-packages it relies on. Originally, it just used the root package as it's peer dependency, but after a suggestion, that was swapped out with the individual packages: #56However, since then there have been a lot of complaints (mostly by people who use yarn as their package manager) about not having all of the included peer dependencies in their
package.json:peerDepswhich are already enforced via Chakra UI itself #47@chakra-ui/systemto peer dependencies #136Ultimately, I've realized that for most people, having
@chakra-ui/reactas the actual peer dependency works best for the majority of users, including myself, as most people are using the package in it's entirety as a dependency, instead of the sub-packages.However, all of the imports are still being pulled in from the sub-packages. I'm not sure if this is the ideal approach, but it's possible this will still allow those who only have the sub-packages installed to use this component if they ignore the peer dependency.