-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import chakraui/icon #277
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d8efd3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an urgent bug fixes
Could we merge this quickly? I am in the process of releasing my app and this came at the worst time possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's wrong to include more than once the same package.
"'@chakra-ui/icon' import is duplicated".
It shouldn't be like this?
import { Icon, IconProps } from '@chakra-ui/icon';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small tweak to remove this dependency in general, but overall LGTM! Thanks for fixing!
There's nothing wrong with this when one of the top level imports is |
Closes #276