Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): checkout core first to cache #317

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Dec 5, 2023

fixes: #315
Basically, when caching the maven files, the key that we use is unique to each version of the pom.xml file. When we checkout the Cryostat repo, which has a different pom.xml file, we are unable to hit the exact key that we saved the cache under because the hashes of the two different pom.xml files are different. Additionally, we are not hitting the cache that was most recently produced for some reason. Therefore, sometimes with changes like the update to 2.26.0-SNAPSHOT, we are actually restoring an older version of -core that hasn't been updated yet.
Here, the change I've made just checks out the -core PR branch before checking out the main Cryostat branch so the right files are cached into the ~/.m2 folder.

@mwangggg
Copy link
Member Author

mwangggg commented Dec 5, 2023

demo: https://github.com/mwangggg/cryostat-core/actions/runs/7102397131/job/19332708073
So this run failed somewhere building Cryostat, but we can see it is caching the right files and compiling 2.26.0-SNAPSHOT

@mwangggg mwangggg added ci chore Refactor, rename, cleanup, etc. safe-to-test labels Dec 5, 2023
@andrewazores
Copy link
Member

That failure is the same as this: https://github.com/cryostatio/cryostat/pull/1808

Cryostat (and Cryostat3) need a small update to be buildable with the latest -core release.

@andrewazores andrewazores merged commit 29fa272 into cryostatio:main Dec 5, 2023
15 of 22 checks passed
@mwangggg mwangggg deleted the 315-CI-core-version branch March 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CI is not correctly caching the PR's -core version
2 participants