feat(jvmid): provide method for determining JVM's own hash ID without JMX connection #309

andrewazores · 2023-11-30T16:49:22Z

Related to cryostatio/cryostat-agent#278

github-actions · 2023-11-30T16:57:07Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64 sh smoketest.sh

github-actions · 2023-11-30T20:51:00Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64 sh smoketest.sh

github-actions · 2023-11-30T21:49:06Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-6a1bb0a8e63f49dd06454ba416668eb59a24be28-linux-arm64 sh smoketest.sh

andrewazores · 2023-11-30T21:51:07Z

/build_test

github-actions · 2023-11-30T21:51:53Z

Cryostat Test: At least one test failed ❌
https://github.com/cryostatio/cryostat-core/actions/runs/7052673314

github-actions · 2023-11-30T21:51:54Z

Image does not exist! Please wait for the initial build and push to complete before using /build_test command.

github-actions · 2023-12-01T14:47:49Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-5801ab499d2a14550de1af205266529ab382e5a9-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-5801ab499d2a14550de1af205266529ab382e5a9-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-5801ab499d2a14550de1af205266529ab382e5a9-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-5801ab499d2a14550de1af205266529ab382e5a9-linux-arm64 sh smoketest.sh

github-actions · 2023-12-01T15:03:13Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-f2194fd4f668b7d4c4fff04067171853d630f513-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-f2194fd4f668b7d4c4fff04067171853d630f513-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-f2194fd4f668b7d4c4fff04067171853d630f513-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-f2194fd4f668b7d4c4fff04067171853d630f513-linux-arm64 sh smoketest.sh

mwangggg · 2023-12-01T18:49:19Z

/build_test

github-actions · 2023-12-01T18:50:01Z

Cryostat Test: At least one test failed ❌
https://github.com/cryostatio/cryostat-core/actions/runs/7063961328

github-actions · 2023-12-01T18:50:02Z

Image does not exist! Please wait for the initial build and push to complete before using /build_test command.

mwangggg · 2023-12-01T19:53:51Z

I don't really understand why this error is occurring... I opened a PR in my forked repo and it's able to pull the image. Thus I can't really test any changes I make to the workflow files to see if they'll fix this issue. I can add a line to make the read packages permission explicit, but otherwise this might not be a permissions problem...

andrewazores · 2023-12-01T19:59:25Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

aali309 · 2023-12-01T21:28:50Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

may be adding : permissions: read after logging in?

      uses: redhat-actions/podman-login@v1
      with:
        registry: ghcr.io/${{ github.repository_owner }}
        username: ${{ github.event.comment.user.login }}
        password: ${{ secrets.GITHUB_TOKEN }} 
        permissions: read
        ```
the current setup looks right though and works well on my local branch too.

mwangggg · 2023-12-03T18:49:47Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

may be adding : permissions: read after logging in?
      uses: redhat-actions/podman-login@v1
      with:
        registry: ghcr.io/${{ github.repository_owner }}
        username: ${{ github.event.comment.user.login }}
        password: ${{ secrets.GITHUB_TOKEN }} 
        permissions: read
        ```
the current setup looks right though and works well on my local branch too.

I'm pretty sure the redhat-actions/podman-login@v1 doesn't have a permissions input: https://github.com/redhat-actions/podman-login#action-inputs

aali309 · 2023-12-03T18:52:55Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

may be adding : permissions: read after logging in?
  uses: redhat-actions/podman-login@v1
  with:
    registry: ghcr.io/${{ github.repository_owner }}
    username: ${{ github.event.comment.user.login }}
    password: ${{ secrets.GITHUB_TOKEN }} 
    permissions: read
    ```
the current setup looks right though and works well on my local branch too.
I'm pretty sure the redhat-actions/podman-login@v1 doesn't have a permissions input: https://github.com/redhat-actions/podman-login#action-inputs

Yes, it doesn't, the current setup look right

mwangggg · 2023-12-03T19:13:22Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

Oh I see what the problem is. https://github.com/cryostatio/cryostat-core/actions/runs/7063961328/job/19231025484#step:1:16 For some reason, only Metadata has read permissions. I'm not sure what happened here, considering the organizational permisisons changes should still provide contents and packages read-only permissions. But explicitly adding the packages: read permissions should fix this error for now until I figure out exactly why they're missing 😄

mwangggg · 2023-12-03T19:36:07Z

I'm not sure either. It's complaining about being "denied", and I can see that the image it tried to pull does actually exist in the container image registry associated with this repository, so I guessed it had to do with the Actions default permissions level change - but that still doesn't sound right, because the change was just from granting read+write to read-only permissions by default. And I would expect that the action being denied only needs permission to read the container image.

Oh I see what the problem is. https://github.com/cryostatio/cryostat-core/actions/runs/7063961328/job/19231025484#step:1:16 For some reason, only Metadata has read permissions. I'm not sure what happened here, considering the organizational permisisons changes should still provide contents and packages read-only permissions. But explicitly adding the packages: read permissions should fix this error for now until I figure out exactly why they're missing 😄

Just kidding... I took at look at the PRs in my forked repo and they also don't include packages: read in the GITHUB_TOKEN Permissions section 😢 I think it might be worth it to still try because the integration test actions in Cryostat include packages and contents read permissions

github-actions · 2023-12-04T14:42:42Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-b7d0e9886ae672bc8d9afd1ee23ef33821deccfb-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-b7d0e9886ae672bc8d9afd1ee23ef33821deccfb-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-b7d0e9886ae672bc8d9afd1ee23ef33821deccfb-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-b7d0e9886ae672bc8d9afd1ee23ef33821deccfb-linux-arm64 sh smoketest.sh

andrewazores · 2023-12-04T14:43:12Z

/build_test

github-actions · 2023-12-04T14:56:55Z

Cryostat Test: At least one test failed ❌
https://github.com/cryostatio/cryostat-core/actions/runs/7088215941

andrewazores · 2023-12-04T14:57:41Z

/build_test

github-actions · 2023-12-04T15:10:47Z

Cryostat Test: All tests pass ✅
https://github.com/cryostatio/cryostat-core/actions/runs/7088387974

aali309

LGTM

aali309 · 2023-12-04T15:18:44Z

LGTM

Just rebase, please.

… JMX connection

github-actions · 2023-12-04T15:27:23Z

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat-core:pr-309-7a574424b5349c58ac99f0e5c08375478afdac44-linux-amd64
arm64	ghcr.io/cryostatio/cryostat-core:pr-309-7a574424b5349c58ac99f0e5c08375478afdac44-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-7a574424b5349c58ac99f0e5c08375478afdac44-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-309-7a574424b5349c58ac99f0e5c08375478afdac44-linux-arm64 sh smoketest.sh

mwangggg · 2023-12-04T17:04:00Z

oh I'm glad adding the permission worked!!

andrewazores · 2023-12-04T17:16:25Z

Any other review thoughts @mwangggg or can I merge this?

mwangggg · 2023-12-04T18:20:54Z

Any other review thoughts @mwangggg or can I merge this?

Looks good to me too 👍

andrewazores added feat New feature or request backport labels Nov 30, 2023

andrewazores mentioned this pull request Nov 30, 2023

feat(management): avoid self-referencing JMX operations cryostatio/cryostat-agent#280

Merged

andrewazores added the safe-to-test label Nov 30, 2023

andrewazores mentioned this pull request Dec 1, 2023

[Bug] CI does not have permissions to download cryostat-core dependency cryostatio/cryostat-legacy#1796

Closed

andrewazores removed the backport label Dec 1, 2023

andrewazores marked this pull request as ready for review December 1, 2023 14:55

andrewazores requested a review from mwangggg December 1, 2023 14:55

andrewazores requested a review from aali309 December 1, 2023 15:07

andrewazores force-pushed the non-jmx-jvmid branch from f2194fd to b7d0e98 Compare December 4, 2023 14:34

aali309 approved these changes Dec 4, 2023

View reviewed changes

andrewazores added 3 commits December 4, 2023 10:19

feat(jvmid): provide method for determining JVM's own hash ID without…

41f50a6

… JMX connection

refactoring

9fbac5d

don't throw exceptions in constructor

7a57442

andrewazores force-pushed the non-jmx-jvmid branch from b7d0e98 to 7a57442 Compare December 4, 2023 15:19

andrewazores merged commit 8249df1 into cryostatio:main Dec 4, 2023
13 checks passed

andrewazores deleted the non-jmx-jvmid branch December 4, 2023 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(jvmid): provide method for determining JVM's own hash ID without JMX connection #309

feat(jvmid): provide method for determining JVM's own hash ID without JMX connection #309

andrewazores commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

andrewazores commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

mwangggg commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

mwangggg commented Dec 1, 2023 •

edited

Loading

andrewazores commented Dec 1, 2023

aali309 commented Dec 1, 2023 •

edited

Loading

mwangggg commented Dec 3, 2023

aali309 commented Dec 3, 2023

mwangggg commented Dec 3, 2023

mwangggg commented Dec 3, 2023 •

edited

Loading

github-actions bot commented Dec 4, 2023

andrewazores commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

andrewazores commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

aali309 left a comment

aali309 commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

mwangggg commented Dec 4, 2023

andrewazores commented Dec 4, 2023

mwangggg commented Dec 4, 2023

feat(jvmid): provide method for determining JVM's own hash ID without JMX connection #309

feat(jvmid): provide method for determining JVM's own hash ID without JMX connection #309

Conversation

andrewazores commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

andrewazores commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

mwangggg commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

mwangggg commented Dec 1, 2023 • edited Loading

andrewazores commented Dec 1, 2023

aali309 commented Dec 1, 2023 • edited Loading

mwangggg commented Dec 3, 2023

aali309 commented Dec 3, 2023

mwangggg commented Dec 3, 2023

mwangggg commented Dec 3, 2023 • edited Loading

github-actions bot commented Dec 4, 2023

andrewazores commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

andrewazores commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

aali309 left a comment

Choose a reason for hiding this comment

aali309 commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

mwangggg commented Dec 4, 2023

andrewazores commented Dec 4, 2023

mwangggg commented Dec 4, 2023

mwangggg commented Dec 1, 2023 •

edited

Loading

aali309 commented Dec 1, 2023 •

edited

Loading

mwangggg commented Dec 3, 2023 •

edited

Loading