E721 and arg-type corrections

greenwiz/cogs/test.py

@@ -60,7 +60,7 @@ async def testdrop(
         if not 1 <= num <= 10:
             raise InvalidInput("Num must be between 1 and 10.")
 
-        if type(member) == discord.Member:
+        if isinstance(member, discord.Member):
             return await ctx.send(
                 f"Interpreted test command as: Send {num} random cryptomonKeys to discord user"
                 f" {member} asa DMed claimlink for reason {reason}."
@@ -102,7 +102,7 @@ async def testdrop(
     @commands.check(nifty())
     @commands.check(scope())
     async def find_words(
-        self, ctx: commands.Context, min_length: int = 4, *, text: str
+        self, ctx: commands.Context(), min_length: int = 4, *, text: str
     ):
 
         test_strings = text.split()

greenwiz/cogs/upland_data.py

@@ -39,7 +39,7 @@ async def visitors(
     response = await session.get(UPLAND_QUERY_URL + str(property_id))
     json_res = await response.json()
     print(json_res)
-    if not type(json_res) == list and json_res.get("code", 200) >= 400:
+    if not isinstance(json_res, list) and json_res.get("code", 200) >= 400:
         raise UnableToCompleteRequestedAction(
             f"I received an invalid response from the upland api: {json_res}"
         )

greenwiz/cogs/wax.py

@@ -328,7 +328,7 @@ async def drop(
         if not 1 <= num <= 10:
             raise InvalidInput("Num must be between 1 and 10.")
 
-        if type(member) == discord.Member:
+        if isinstance(member, discord.Member):
             log(
                 f"Sending {num} random cryptomonKeys to discord user {member} as a DMed claimlink for reason {reason}",
                 "DBUG",

greenwiz/utils/storage.py

@@ -58,7 +58,7 @@ async def get_settings(self, num: int = 1000) -> dict[str, str]:
         results = dict()
         for key in keys:
             id_ = str(key).split(":")[-1][:-1]
-            if await self.redis.type(key) == b"string":
+            if await self.redis.type(key) == b"string":  # noqa: E721
                 value = await self.redis.get(key)
             else:
                 value = await self.redis.hgetall(key)

greenwiz/wax_chain/wax_util.py

@@ -221,7 +221,7 @@ def format_wax_amount(amount):
 def get_resp_code(response):
     """Wax nodes don't always follow HTTP standards let alone RESTful best practices."""
     code = response.get("code", 0)
-    if code == 0 or not type(code) == int:
+    if code == 0 or not isinstance(code, int):
         code = response.get("statusCode", 0)
     try:
         code = int(code)
@@ -1058,6 +1058,9 @@ async def send_link_start_to_finish(
     if not isinstance(member, discord.abc.Snowflake):
         raise AssertionError("Guild member' should always be a Member.")
     while intro:
+        if not isinstance(introduced, discord.abc.Snowflake):
+            raise AssertionError("When post is classed as an intro and introduced role is defined,"
+                                 " introduced role should be addable.")
         # To ensure it gets added if discord messes up initially
         await member.add_roles(introduced)
         if introduced in member.roles: