Automatically detect criteo IP address for checks #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lqp1
approved these changes
Sep 13, 2023
This should remove the constraint on Mesos to configure `criteo` network in a specific order (last element). With patch, the effective address of the current task should be assign the criteo network's (first) IP address (if it is defined), otherwise we will fall back to the previous heuristic (extract the first IP address provided by Mesos). JIRA: MESOS-5907
komuta
force-pushed
the
multi-cni-networks
branch
from
799951d
to
137f9c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the constraint on Mesos to configure
criteonetwork in a specific order (last element). With patch, the effective address of the current task should be assign the criteo network's (first) IP address (if it is defined), otherwise we will fall back to the previous heuristic (extract the first IP address provided by Mesos).JIRA: MESOS-5907