Support time-series popup for MultiPolygonSeries covjson #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently, the playground does not show a popup for `MultiPolygonSeries` covjson files and instead displays a `No data` popup when a polygon is clicked. - This change fixes that
ThorodanBrom
force-pushed
the
patch-1
branch
from
f7b5d2d
to
d82cb86
Compare
|
This looks like a simple and uncontroversial change, but I've requested a review from @letmaik as I'm not familiar with this code base. |
|
@ThorodanBrom Thanks for the PR. Did you test that your change works locally? |
|
Hello @letmaik, I made the change to a local instance of the playground and I can confirm that it works with a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiPolygonSeriescovjson files and instead displays aNo datapopup when a polygon is clicked.