Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current development JSON schema #6

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Add current development JSON schema #6

merged 2 commits into from
Apr 27, 2022

Conversation

letmaik
Copy link
Member

@letmaik letmaik commented Apr 27, 2022

@jonblower
Copy link
Member

A couple of questions (in my ignorance of how these things are done):

  1. Should we make the schema compact (removing unnecessary whitespace?)
  2. Does the schema need to declare which version of JSON-Schema it supports?

@letmaik
Copy link
Member Author

letmaik commented Apr 27, 2022

A couple of questions (in my ignorance of how these things are done):

1. Should we make the schema compact (removing unnecessary whitespace?)

I don't think so. If anyone has a need for it, they can compact it themselves, but typically schemas are not published compacted.

2. Does the schema need to declare which version of JSON-Schema it supports?

Yes, it does actually, in line 80. Should probably change the code to make sure this is at the top to avoid confusion.

@jonblower
Copy link
Member

OK, that's all fine with me then. If it's quick to change the code to put the schema version at the top, I suggest doing that, but no worries if it's a pain.

I'll leave you to squash and merge - take this as unofficial PR approval!

@letmaik letmaik merged commit f9395f2 into master Apr 27, 2022
@letmaik letmaik deleted the letmaik/dev-schema branch April 27, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants