Skip to content

Commit

Permalink
minor cleanup of grid and verticalprofile tests (#36)
Browse files Browse the repository at this point in the history
  • Loading branch information
letmaik authored Jun 22, 2022
1 parent c278fa8 commit 4e8cf67
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
19 changes: 2 additions & 17 deletions test/domain_types/test_grid.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,29 +61,14 @@ def test_empty_t_axis(validator, grid_domain):
validator.validate(grid_domain)


def test_extra_multi_coordinate_axis(validator, grid_domain):
''' Invalid: Grid domain with unrecognised multi-coordinate axis '''
def test_extra_coordinate_axis(validator, grid_domain):
''' Invalid: Grid domain with unrecognised axis '''

grid_domain["axes"]["x2"] = grid_domain["axes"]["x"]
with pytest.raises(ValidationError):
validator.validate(grid_domain)


# TODO the schema forbids this currently, but the spec allows it
# def test_extra_single_coordinate_axis(validator, grid_domain):
# ''' Valid: Grid domain with unrecognised single-coordinate axis '''

# grid_domain["axes"]["x2"] = { "values": [1] }
# grid_domain["referencing"].append({
# "coordinates": ["x2"],
# "system": {
# "type": "GeographicCRS",
# "id": "http://foo"
# }
# })
# validator.validate(grid_domain)


def test_wrong_x_axis_type_with_no_domain_type(validator, grid_domain):
''' Grid domain with a tuple axis instead of a primitive one, but
there is no domainType so it will validate '''
Expand Down
1 change: 0 additions & 1 deletion test/domain_types/test_verticalprofile.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def test_multivalued_y_axis(validator, verticalprofile_domain):
validator.validate(verticalprofile_domain)


# TODO: this is not explicity forbidden in the spec, but should be - see #96
def test_multivalued_t_axis(validator, verticalprofile_domain):
''' Invalid: VerticalProfile domain with multi-valued 't' axis '''

Expand Down

0 comments on commit 4e8cf67

Please sign in to comment.