Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP agent -> Pinner multipart upload fix #280

Closed
wants to merge 6 commits into from

Conversation

tarassh
Copy link

@tarassh tarassh commented Aug 22, 2024

WriteField should be used only for text fields.
CreateFormFile + part.Write send binary content.

PS. Pinner has also to be adjusted.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.52%. Comparing base (d0f896c) to head (7908393).
Report is 9 commits behind head on develop.

Files Patch % Lines
internal/storage/ipfs.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
- Coverage    15.54%   15.52%   -0.02%     
===========================================
  Files           53       53              
  Lines         6171     6176       +5     
===========================================
  Hits           959      959              
- Misses        5164     5169       +5     
  Partials        48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarassh tarassh changed the title fix BSP agent -> Pinner multipart upload fix Aug 23, 2024
@noslav noslav changed the base branch from main to develop August 27, 2024 16:42
@noslav
Copy link
Member

noslav commented Aug 27, 2024

@tarassh Closing in favor of merged #282. All new PRs should always point to develop (and branch off from there as well) from where we can test it in the ovh test env

@noslav noslav closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants