Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: More rigorous CosmWasm check and upgrade dependencies #992

Merged
merged 12 commits into from
Dec 1, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Nov 27, 2023

Closes: #991

Description

Parity primitives-types are disallowed for wasm32 and std.

But because in wasm32 std and no std bind to same types, can use parity types without std in wasm32 or native.

In case of when std != no_std (for example Solana), it is not wasm and no_std, so it should work too.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: see updates to build.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft November 27, 2023 22:58
@dzmitry-lahoda dzmitry-lahoda changed the title chore: drat chore: Making cosmwasm compile apps transfers Nov 27, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review November 27, 2023 23:08
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c7d719) 70.86% compared to head (45724dc) 70.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files         178      178           
  Lines       17918    17918           
=======================================
  Hits        12698    12698           
  Misses       5220     5220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dzmitry-lahoda, thanks for the improvements!
The primitive-types/std glitch should be fixed on the parity-common. I've opened this PR there and tested locally. It worked.
Let's wrap up the acceptable changes of this PR. But we'll keep issue #991 open until parity's sorted.

ci/cw-check/Cargo.toml Outdated Show resolved Hide resolved
ci/cw-check/README.md Outdated Show resolved Hide resolved
ibc-apps/ics20-transfer/types/Cargo.toml Outdated Show resolved Hide resolved
dzmitry-lahoda and others added 5 commits December 1, 2023 09:02
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
…-apps-transfers.md

Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@Farhad-Shabani Farhad-Shabani changed the title chore: Making cosmwasm compile apps transfers chore: More rigorous CosmWasm check and upgrade dependencies Dec 1, 2023
@Farhad-Shabani Farhad-Shabani merged commit fe9a26b into cosmos:main Dec 1, 2023
14 checks passed
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* clean up

* remaining

* up

* spelling

* true check

* better nix - features enabled + gh cache integration

* flag

* Update ci/cw-check/Cargo.toml

Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* Update ci/cw-check/README.md

Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* Update .changelog/unreleased/improvements/992-making-cosmwasm-compile-apps-transfers.md

Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* Update Cargo.toml

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

---------

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat/question: support compilation to wasm32 with std
2 participants