-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to typescript and add Dark Mode #56
Switch to typescript and add Dark Mode #56
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maxslarsson and the rest of your teammates on Graphite |
35f0ed2
to
cfb8652
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/26/24)1 reviewer was added to this PR based on Zach Garcia's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the Dockerfile back so I can pull that image too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out your code, and grpc works fine for me. We should make sure it works for you too though. Just to double check, here are the steps I took:
- navigate to ground-server
- run npm install
- run npm run dev
- docker run -it -d --network=host ghcr.io/cornellrocketryteam/fill-station
- Navigate to localhost:3000/grpc and refresh if necessary
I get the error: Error: Cannot Connect. Is the Fill Station Running? Error: 14 UNAVAILABLE: No connection established. Last error: connect ECONNREFUSED 127.0.0.1:50051 (2024-09-26T02:43:08.025Z) |
cfb8652
to
7edd14e
Compare
I'll investigate on a Pi tomorrow to make sure it's not an ARM issue. Let's hold off merging until then. If that works for me, it's probably some firewall rule on your Mac? |
Yes probably, sounds good |
It works fine on a pi with fill-station:main (an older image) the arm64 version seems broken in the :latest image. Created a ticket to track fixing this |
e84a73e
to
1258efa
Compare
1258efa
to
017f783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the work!
Merge activity
|
No description provided.