Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to typescript and add Dark Mode #56

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

maxslarsson
Copy link
Contributor

No description provided.

Copy link
Contributor Author

maxslarsson commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maxslarsson and the rest of your teammates on Graphite Graphite

@maxslarsson maxslarsson force-pushed the 09-25-switch_to_typescript_and_add_dark_mode branch from 35f0ed2 to cfb8652 Compare September 26, 2024 01:46
@maxslarsson maxslarsson marked this pull request as ready for review September 26, 2024 01:53
Copy link

graphite-app bot commented Sep 26, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/26/24)

1 reviewer was added to this PR based on Zach Garcia's automation.

Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the Dockerfile back so I can pull that image too?

Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your code, and grpc works fine for me. We should make sure it works for you too though. Just to double check, here are the steps I took:

  1. navigate to ground-server
  2. run npm install
  3. run npm run dev
  4. docker run -it -d --network=host ghcr.io/cornellrocketryteam/fill-station
  5. Navigate to localhost:3000/grpc and refresh if necessary

Copy link
Contributor Author

I get the error:

Error: Cannot Connect. Is the Fill Station Running? Error: 14 UNAVAILABLE: No connection established. Last error: connect ECONNREFUSED 127.0.0.1:50051 (2024-09-26T02:43:08.025Z)

@maxslarsson maxslarsson force-pushed the 09-25-switch_to_typescript_and_add_dark_mode branch from cfb8652 to 7edd14e Compare September 26, 2024 02:46
Copy link
Contributor

I get the error:

Error: Cannot Connect. Is the Fill Station Running? Error: 14 UNAVAILABLE: No connection established. Last error: connect ECONNREFUSED 127.0.0.1:50051 (2024-09-26T02:43:08.025Z)

I'll investigate on a Pi tomorrow to make sure it's not an ARM issue. Let's hold off merging until then. If that works for me, it's probably some firewall rule on your Mac?

Copy link
Contributor Author

Yes probably, sounds good

@maxslarsson maxslarsson mentioned this pull request Sep 26, 2024
Copy link
Contributor

It works fine on a pi with fill-station:main (an older image) the arm64 version seems broken in the :latest image. Created a ticket to track fixing this

@maxslarsson maxslarsson force-pushed the 09-25-switch_to_typescript_and_add_dark_mode branch 2 times, most recently from e84a73e to 1258efa Compare September 26, 2024 19:31
@maxslarsson maxslarsson force-pushed the 09-25-switch_to_typescript_and_add_dark_mode branch from 1258efa to 017f783 Compare September 26, 2024 19:39
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the work!

Copy link
Contributor Author

maxslarsson commented Sep 26, 2024

Merge activity

@maxslarsson maxslarsson merged commit bdd055e into main Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants