Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions on merge to main #51

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ZachGarcia42
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 commented Sep 25, 2024

TL;DR

Updated GitHub Actions workflow for improved caching and tagging strategies. If no bazel changes, Fill Station CI completes in <2 minutes now!!

What changed?

  • Modified the disk-cache key to include the architecture matrix value, ensuring separate caches for different architectures.
  • Updated the Docker image tagging strategy:
    • Disabled branch-based tagging for the main branch.
    • Enabled branch-based tagging only for non-main branches.

How to test?

  1. Trigger the workflow on different branches and architectures.
  2. Verify that the disk cache is correctly separated by architecture.
  3. Check the generated Docker image tags:
    • Ensure 'latest' tag is only applied on the default branch.
    • Confirm branch-based tags are not created for the main branch.
    • Validate that branch-based tags are created for other branches.

Why make this change?

  • To optimize caching by separating caches for different architectures, potentially improving build times.
  • To refine the Docker image tagging strategy, ensuring more accurate and meaningful tags for different branches and pull requests.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ZachGarcia42 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 25, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/25/24)

1 reviewer was added to this PR based on Zach Garcia's automation.

@ZachGarcia42 ZachGarcia42 merged commit ea2cac0 into main Sep 25, 2024
5 checks passed
Copy link
Contributor Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants