Replace explicit features and paths on generated code #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move feature detection to before generating code. - Only emits the `SaveSafeTensors` and `LoadSafeTensors` derivations and the `#[serialize]` attr if the `safetensors` feature is enabled.
- Re-export the `self` crate as `dfdx`. - See [related question](https://users.rust-lang.org/t/how-to-express-crate-path-in-procedural-macros/91274/10). - Does the same for `dfdx-core`. - Change the generated code so they always have the `::dfdx` path entrypoint. - User apps no longer need to depend on `dfdx-core` or `dfdx-derives` directly. - Re-export `safetensors`. - User apps no longer need to depend on `safetensors` directly (as in, this is no longer required by the `SaveSafeTensors` and `LoadSafeTensors` derivations).
swfsql
changed the title
::dfdx as a path entrypoint on code generation
coreylowman
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #885 .
SaveSafeTensorsandLoadSafeTensorsderivations (as in, injecting the derivation command, not the final derivation itself) and the#[serialize]attr if thedfdx/safetensorsfeature is enabled.dfdx-derives/safetensorsfeature.safetensorsfeature directly.::dfdxas a path entrypoint on code generationselfcrate asdfdx.dfdx-core.::dfdxpath entrypoint.dfdx-corenordfdx-derivesdirectly.safetensorslib.safetensorsdirectly (as in, this is no longer required by theSaveSafeTensorsandLoadSafeTensorsderivations).