Various small fixes #814
Merged
Various small fixes #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
reviewed
Jul 14, 2023
src/tensor_ops/matmul/cpu_kernel.rs
Outdated
Comment on lines
74
to
81
| cp as *mut gemm::f16, | ||
| cp, | ||
| cstr[1] as isize, | ||
| cstr[0] as isize, | ||
| accum, | ||
| ap as *const gemm::f16, | ||
| ap, | ||
| astr[1] as isize, | ||
| astr[0] as isize, | ||
| bp as *const gemm::f16, | ||
| bp, |
There was a problem hiding this comment.
We still need these - internally gemm does a TypeId check against the type. So if gemm is using a different version of the half crate than dfdx, this will fail.
coreylowman
requested changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny pr that resolves multiple issues too small to deserve their own pr. It makes the following changes:
half::f16inshapes/mod.rs, which resolves Re-exporthalf::f16in lib.rs if f16 feature is enabled #810.Gradients::get_or_alloc_mutpublic, which resolves Make Gradients::get_or_alloc_mut pub #809.get_or_alloc_mutandGradients::getto work with any implementer of TensorLike.Gradients::try_alloc_forpublicTensor::ghostpublic (GhostTensor was already public, there just wasn't any way to construct it)