feat(node): separate tracing and logging files #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Aug 30, 2024
Comment on lines
+28
to
+31
| pub fn set_global_tracing_subscriber( | ||
| config: &TracingSettings, | ||
| ) -> Option<(WorkerGuard, WorkerGuard)> { | ||
| let (logs_file_layer, traces_file_layer, file_guards) = match &config.file { |
There was a problem hiding this comment.
The complexity of this method is too high. It's really hard to follow what it does, and we could document it better as well. I'm going to take a stab at improving this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1084