Skip to content

Commit

Permalink
Fix x-sns validation (#690)
Browse files Browse the repository at this point in the history
* x-sns spec validation

* Disabling waf lookup tests
  • Loading branch information
JohnPreston committed Sep 24, 2023
1 parent 7a7c3ef commit 7cd3b19
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 2 deletions.
26 changes: 26 additions & 0 deletions ecs_composex/sns/x-sns.spec.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"id": "x-sns.spec.json",
"$id": "x-sns.spec.json",
"title": "x-sns",
"description": "x-sns specification",
"type": "object",
"properties": {
"Lookup": {
"$ref": "x-resources.common.spec.json#/definitions/Lookup"
},
"Properties": {
"type": "object",
"description": "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-topic.html"
},
"Settings": {
"$ref": "x-resources.common.spec.json#/definitions/Settings"
},
"Services": {
"$ref": "x-resources.common.spec.json#/definitions/Services"
}
},
"patternProperties": {
"x-": {}
}
}
4 changes: 2 additions & 2 deletions tests/features/features/wafv2.feature
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ Feature: ecs_composex.wafv2_webacl
Examples:
| file_path | override_file |
| use-cases/blog.features.yml | use-cases/wafv2_webacl/create_only.yaml |
| use-cases/blog.features.yml | use-cases/wafv2_webacl/lookup_only.yaml |
# | use-cases/blog.features.yml | use-cases/wafv2_webacl/lookup_only.yaml |
| use-cases/blog.features.yml | use-cases/wafv2_webacl/create_only_with_elbv2.yaml |
| use-cases/blog.features.yml | use-cases/wafv2_webacl/lookup_only_with_elbv2.yaml |
# | use-cases/blog.features.yml | use-cases/wafv2_webacl/lookup_only_with_elbv2.yaml |

0 comments on commit 7cd3b19

Please sign in to comment.