Skip to content

Commit

Permalink
Given the secret ID is always passed via parameter, using Parameter name
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnPreston committed Nov 15, 2023
1 parent 92184be commit 76e6018
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions ecs_composex/rds_resources_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ def generate_secret_string(
"""
from troposphere.secretsmanager import Secret

param_name = secret_import.data["Ref"]
secret, already_set = set_get_resource(
family.template,
Secret(
Expand All @@ -244,32 +245,32 @@ def generate_secret_string(
"${ENGINE}://${USERNAME}:${PASSWORD}@${HOST}:${PORT}/${DBNAME}",
ENGINE=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:engine}}",
),
USERNAME=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:username}}",
),
PASSWORD=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:password}}",
),
HOST=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:host}}",
),
PORT=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:port}}",
),
DBNAME=Sub(
"{{resolve:secretsmanager:"
+ f"${{{secret_import.title}}}"
+ f"${{{param_name}}}"
+ ":SecretString:dbname}}",
),
),
Expand Down

0 comments on commit 76e6018

Please sign in to comment.