Fix: timebase ps4000a #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you believe that the 4824 and the 4000a are the same. is that correct? |
|
In the documentation So yes I believe they are the same for the timebase calculation |
|
Could you please release a new version, so the 4000 series can be used easily. Thank you. |
|
Sorry for the delay: https://github.com/colinoflynn/pico-python/releases/tag/0.7.28 |
|
Thanks for cleaning up the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timebase calculation for ps4000a devices was wrong:
See 3.7 Timebases from https://www.picotech.com/download/manuals/picoscope-4000-series-a-api-programmers-guide.pdf.