feat: Make the camera manager marker better #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpriori
reviewed
Sep 20, 2024
viewer/packages/camera-manager/src/Flexible/FlexibleCameraMarkers.ts
Outdated
Show resolved
Hide resolved
danpriori
approved these changes
Sep 20, 2024
nilscognite
added
the
auto-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
Now, the marker will be render with a weaker color when it is behind something in the scene. This is made by two marker, one with depth test and one transparent without depth test.
In front:
Behind something:
Test instructions ℹ️
Go to reveal/examples
Run.